Changeset 46462

Timestamp:

10/11/2019 11:52:11 PM (7 years ago)

Author:

SergeyBiryukov

Message:

Formatting: Make sure wp_sanitize_redirect() encodes spaces in URLs instead of stripping them out.

Props donmhico, hlashbrooke, dd32, azaozz.
Fixes #36998.

Location:

trunk

Files:

• src/wp-includes/pluggable.php (modified) (2 diffs)
• tests/phpunit/tests/formatting/redirect.php (modified) (1 diff)

trunk/src/wp-includes/pluggable.php

@@ -1281 +1281 @@
          */
         function wp_sanitize_redirect( $location ) {
+                // Encode spaces.
+                $location = str_replace( ' ', '%20', $location );
+
                 $regex    = '/
                 (
@@ -1297 +1300 @@
                 $location = wp_kses_no_null( $location );
 
-                // remove %0d and %0a from location
+                // Remove %0D and %0A from location.
                 $strip = array( '%0d', '%0a', '%0D', '%0A' );
                 return _deep_replace( $strip, $location );

trunk/tests/phpunit/tests/formatting/redirect.php

@@ -35 +35 @@
                 $this->assertEquals( 'http://example.com/search.php?search=(amistillhere)', wp_sanitize_redirect( 'http://example.com/search.php?search=(amistillhere)' ) );
                 $this->assertEquals( 'http://example.com/@username', wp_sanitize_redirect( 'http://example.com/@username' ) );
+        }
+
+        /**
+         * @group 36998
+         */
+        function test_wp_sanitize_redirect_should_encode_spaces() {
+                $this->assertEquals( 'http://example.com/test%20spaces', wp_sanitize_redirect( 'http://example.com/test%20spaces' ) );
+                $this->assertEquals( 'http://example.com/test%20spaces%20in%20url', wp_sanitize_redirect( 'http://example.com/test spaces in url' ) );
         }