Changeset 46474

Timestamp:

10/14/2019 03:18:49 PM (5 years ago)

Author:

whyisjake

Message:

Query: Remove the static query property.

Prevent unauthenticated views of publicly queryables content types.

Props aaroncampbell, whyisjake, nickdaugherty, xknown.

Location:

trunk

Files:

• src/wp-includes/class-wp-query.php (modified) (2 diffs)
• src/wp-includes/class-wp.php (modified) (1 diff)
• tests/phpunit/tests/query/vars.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-query.php

@@ -539 +539 @@
             'attachment_id',
             'name',
-            'static',
             'pagename',
             'page_id',
@@ -806 +805 @@
             // post is being queried.
             $this->is_single = true;
-        } elseif ( '' != $qv['static'] || '' != $qv['pagename'] || ! empty( $qv['page_id'] ) ) {
+        } elseif ( '' != $qv['pagename'] || ! empty( $qv['page_id'] ) ) {
             $this->is_page   = true;
             $this->is_single = false;

trunk/src/wp-includes/class-wp.php

@@ -15 +15 @@
      * @var string[]
      */
-    public $public_query_vars = array( 'm', 'p', 'posts', 'w', 'cat', 'withcomments', 'withoutcomments', 's', 'search', 'exact', 'sentence', 'calendar', 'page', 'paged', 'more', 'tb', 'pb', 'author', 'order', 'orderby', 'year', 'monthnum', 'day', 'hour', 'minute', 'second', 'name', 'category_name', 'tag', 'feed', 'author_name', 'static', 'pagename', 'page_id', 'error', 'attachment', 'attachment_id', 'subpost', 'subpost_id', 'preview', 'robots', 'taxonomy', 'term', 'cpage', 'post_type', 'embed' );
+    public $public_query_vars = array( 'm', 'p', 'posts', 'w', 'cat', 'withcomments', 'withoutcomments', 's', 'search', 'exact', 'sentence', 'calendar', 'page', 'paged', 'more', 'tb', 'pb', 'author', 'order', 'orderby', 'year', 'monthnum', 'day', 'hour', 'minute', 'second', 'name', 'category_name', 'tag', 'feed', 'author_name', 'pagename', 'page_id', 'error', 'attachment', 'attachment_id', 'subpost', 'subpost_id', 'preview', 'robots', 'taxonomy', 'term', 'cpage', 'post_type', 'embed' );
 
     /**

trunk/tests/phpunit/tests/query/vars.php

@@ -52 +52 @@
                 'feed',
                 'author_name',
-                'static',
                 'pagename',
                 'page_id',