WordPress.org

Make WordPress Core


Ignore:
Timestamp:
10/14/2019 05:33:34 PM (4 months ago)
Author:
whyisjake
Message:

Administration: Ensure that admin referer nonce is valid.

Coding standards, ensure that nonce is valid with identical, rather then equal operator.

Backports [46477] to the 5.2 branch.
Props vortfu, xknown, whyisjake.

Location:
branches/5.2
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • branches/5.2

  • branches/5.2/src/wp-includes/pluggable.php

    r46473 r46486  
    10931093     */
    10941094    function check_admin_referer( $action = -1, $query_arg = '_wpnonce' ) {
    1095         if ( -1 == $action ) {
     1095        if ( -1 === $action ) {
    10961096            _doing_it_wrong( __FUNCTION__, __( 'You should specify a nonce action to be verified by using the first parameter.' ), '3.2.0' );
    10971097        }
     
    11121112        do_action( 'check_admin_referer', $action, $result );
    11131113
    1114         if ( ! $result && ! ( -1 == $action && strpos( $referer, $adminurl ) === 0 ) ) {
     1114        if ( ! $result && ! ( -1 === $action && strpos( $referer, $adminurl ) === 0 ) ) {
    11151115            wp_nonce_ays( $action );
    11161116            die();
Note: See TracChangeset for help on using the changeset viewer.