Changeset 46563 for trunk/src/wp-includes/rest-api/fields/class-wp-rest-meta-fields.php

Timestamp:

10/21/2019 07:08:34 PM (5 years ago)

Author:

kadamwhite

Message:

REST API: Cast empty meta values to correct scalar types in REST response.

Introducing complex meta value handling in [45807] unintentionally removed value casting for empty scalar meta values.

Props TimothyBlynJacobs, chrisvanpatten, rmccue, kadamwhite.
Fixes #48363.

File:

• trunk/src/wp-includes/rest-api/fields/class-wp-rest-meta-fields.php (modified) (4 diffs)

trunk/src/wp-includes/rest-api/fields/class-wp-rest-meta-fields.php

@@ -431 +431 @@
 
             if ( null === $rest_args['schema']['default'] ) {
-                $rest_args['schema']['default'] = $this->get_default_for_type( $type );
+                $rest_args['schema']['default'] = static::get_empty_value_for_type( $type );
             }
 
@@ -502 +502 @@
         }
 
+        if ( '' === $value && in_array( $schema['type'], array( 'boolean', 'integer', 'number' ), true ) ) {
+            $value = static::get_empty_value_for_type( $schema['type'] );
+        }
+
         if ( is_wp_error( rest_validate_value_from_schema( $value, $schema ) ) ) {
             return null;
@@ -560 +564 @@
 
     /**
-     * Gets the default value for a schema type.
+     * Gets the empty value for a schema type.
      *
      * @since 5.3.0
@@ -567 +571 @@
      * @return mixed
      */
-    protected function get_default_for_type( $type ) {
+    protected static function get_empty_value_for_type( $type ) {
         switch ( $type ) {
             case 'string':