Changeset 46570

Timestamp:

10/22/2019 05:50:45 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Administration: Relax the default value check for the $position argument added to add_submenu_page() and related functions in [46197].

Due to a confusion with add_menu_page(), which takes the $icon_url parameter, while add_submenu_page() does not, some plugins were passing in a string instead of integer as $position, causing backward compatibility issues.

A _doing_it_wrong() message is now added to alert developers of the wrong parameter type.

Props david.binda, desrosj, 123host, dennis_f, MattyRob.
Reviewed by desrosj.
Fixes #48249.

File:

• trunk/src/wp-admin/includes/plugin.php (modified) (1 diff)

trunk/src/wp-admin/includes/plugin.php

@@ -1374 +1374 @@
 
     $new_sub_menu = array( $menu_title, $capability, $menu_slug, $page_title );
-    if ( null === $position ) {
+    if ( ! is_int( $position ) ) {
+        if ( null !== $position ) {
+            _doing_it_wrong(
+                __FUNCTION__,
+                sprintf(
+                    /* translators: %s: add_submenu_page() */
+                    __( 'The seventh parameter passed to %s should be an integer representing menu position.' ),
+                    '<code>add_submenu_page()</code>'
+                ),
+                '5.3.0'
+            );
+        }
+
         $submenu[ $parent_slug ][] = $new_sub_menu;
     } else {