Changeset 46578

Timestamp:

10/25/2019 12:49:40 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Date/Time: Correct the logic in WP_Posts_List_Table::column_date() and WP_Media_List_Table::column_date() to check for a valid post timestamp.

Props Rarst.
Reviewed by azaozz, SergeyBiryukov.
See #48384.

Location:

trunk/src/wp-admin/includes

Files:

• class-wp-media-list-table.php (modified) (1 diff)
• class-wp-posts-list-table.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-wp-media-list-table.php

@@ -453 +453 @@
             $h_time = __( 'Unpublished' );
         } else {
-            $m_time = $post->post_date;
-            $time   = get_post_time( 'G', true, $post, false );
-            $t_diff = time() - $time;
-            if ( ( abs( $t_diff ) ) < DAY_IN_SECONDS ) {
-                if ( $t_diff < 0 ) {
-                    /* translators: %s: Human-readable time difference. */
-                    $h_time = sprintf( __( '%s from now' ), human_time_diff( $time ) );
-                } else {
-                    /* translators: %s: Human-readable time difference. */
-                    $h_time = sprintf( __( '%s ago' ), human_time_diff( $time ) );
-                }
+            $time      = get_post_timestamp( $post );
+            $time_diff = time() - $time;
+
+            if ( $time && $time_diff > 0 && $time_diff < DAY_IN_SECONDS ) {
+                /* translators: %s: Human-readable time difference. */
+                $h_time = sprintf( __( '%s ago' ), human_time_diff( $time ) );
             } else {
-                $h_time = mysql2date( __( 'Y/m/d' ), $m_time );
+                $h_time = get_the_time( __( 'Y/m/d' ), $post );
             }
         }

trunk/src/wp-admin/includes/class-wp-posts-list-table.php

@@ -1067 +1067 @@
             $time_diff = 0;
         } else {
-            $t_time = get_the_time( __( 'Y/m/d g:i:s a' ) );
-            $m_time = $post->post_date;
-            $time   = get_post_time( 'G', true, $post );
-
+            $t_time    = get_the_time( __( 'Y/m/d g:i:s a' ), $post );
+            $time      = get_post_timestamp( $post );
             $time_diff = time() - $time;
 
-            if ( $time_diff > 0 && $time_diff < DAY_IN_SECONDS ) {
+            if ( $time && $time_diff > 0 && $time_diff < DAY_IN_SECONDS ) {
                 /* translators: %s: Human-readable time difference. */
                 $h_time = sprintf( __( '%s ago' ), human_time_diff( $time ) );
             } else {
-                $h_time = mysql2date( __( 'Y/m/d' ), $m_time );
+                $h_time = get_the_time( __( 'Y/m/d' ), $post );
             }
         }
@@ -1584 +1582 @@
                         $users_opt['show_option_none'] = __( '&mdash; No Change &mdash;' );
                     }
+
+                    /**
+                     * Filters the arguments used to generate the Quick Edit authors drop-down.
+                     *
+                     * @since 5.3.0
+                     *
+                     * @see wp_dropdown_users()
+                     *
+                     * @param array $users_opt An array of arguments for wp_dropdown_users function.
+                     * @param bool  $bulk      A boolean to know if it's a bulk action or not.
+                     */
+                    $users_opt = apply_filters( 'quick_edit_authors_query_args', $users_opt, $bulk );
 
                     $authors = wp_dropdown_users( $users_opt );