Make WordPress Core


Ignore:
Timestamp:
10/25/2019 12:49:40 PM (5 years ago)
Author:
SergeyBiryukov
Message:

Date/Time: Correct the logic in WP_Posts_List_Table::column_date() and WP_Media_List_Table::column_date() to check for a valid post timestamp.

Props Rarst.
Reviewed by azaozz, SergeyBiryukov.
See #48384.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/includes/class-wp-media-list-table.php

    r46418 r46578  
    453453            $h_time = __( 'Unpublished' );
    454454        } else {
    455             $m_time = $post->post_date;
    456             $time   = get_post_time( 'G', true, $post, false );
    457             $t_diff = time() - $time;
    458             if ( ( abs( $t_diff ) ) < DAY_IN_SECONDS ) {
    459                 if ( $t_diff < 0 ) {
    460                     /* translators: %s: Human-readable time difference. */
    461                     $h_time = sprintf( __( '%s from now' ), human_time_diff( $time ) );
    462                 } else {
    463                     /* translators: %s: Human-readable time difference. */
    464                     $h_time = sprintf( __( '%s ago' ), human_time_diff( $time ) );
    465                 }
     455            $time      = get_post_timestamp( $post );
     456            $time_diff = time() - $time;
     457
     458            if ( $time && $time_diff > 0 && $time_diff < DAY_IN_SECONDS ) {
     459                /* translators: %s: Human-readable time difference. */
     460                $h_time = sprintf( __( '%s ago' ), human_time_diff( $time ) );
    466461            } else {
    467                 $h_time = mysql2date( __( 'Y/m/d' ), $m_time );
     462                $h_time = get_the_time( __( 'Y/m/d' ), $post );
    468463            }
    469464        }
Note: See TracChangeset for help on using the changeset viewer.