Make WordPress Core


Ignore:
Timestamp:
10/29/2019 02:26:41 PM (7 years ago)
Author:
SergeyBiryukov
Message:

Build/Test Tools: Ignore EOL differences in tests using multiline string assertions.

Unix vs. Windows EOL style mismatches can cause misleading failures in tests using the heredoc syntax (<<<) or multiline strings as the expected result.

Fixes #31432. See #42594, #47411.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/tests/dependencies/scripts.php

    r46586 r46612  
    847847                $expected .= "<script type='text/javascript' src='/wp-includes/js/script.js'></script>\n";
    848848
    849                 $this->assertEquals( $expected, get_echo( 'wp_print_scripts' ) );
     849                $this->assertEqualsIgnoreEOL( $expected, get_echo( 'wp_print_scripts' ) );
    850850        }
    851851
     
    872872                $expected .= "<script type='text/javascript' src='/wp-content/plugins/my-plugin/js/script.js'></script>\n";
    873873
    874                 $this->assertEquals( $expected, get_echo( 'wp_print_scripts' ) );
     874                $this->assertEqualsIgnoreEOL( $expected, get_echo( 'wp_print_scripts' ) );
    875875        }
    876876
     
    897897                $expected .= "<script type='text/javascript' src='/wp-content/themes/my-theme/js/script.js'></script>\n";
    898898
    899                 $this->assertEquals( $expected, get_echo( 'wp_print_scripts' ) );
     899                $this->assertEqualsIgnoreEOL( $expected, get_echo( 'wp_print_scripts' ) );
    900900        }
    901901
     
    922922                $expected .= "<script type='text/javascript' src='/wp-admin/js/script.js'></script>\n";
    923923
    924                 $this->assertEquals( $expected, get_echo( 'wp_print_scripts' ) );
     924                $this->assertEqualsIgnoreEOL( $expected, get_echo( 'wp_print_scripts' ) );
    925925        }
    926926
     
    962962                $expected .= "<script type='text/javascript' src='/wp-admin/js/script.js'></script>\n";
    963963
    964                 $this->assertEquals( $expected, get_echo( 'wp_print_scripts' ) );
     964                $this->assertEqualsIgnoreEOL( $expected, get_echo( 'wp_print_scripts' ) );
    965965        }
    966966
     
    989989                $expected .= "<script type='text/javascript' src='/wp-includes/js/script.js'></script>\n";
    990990
    991                 $this->assertEquals( $expected, get_echo( 'wp_print_scripts' ) );
     991                $this->assertEqualsIgnoreEOL( $expected, get_echo( 'wp_print_scripts' ) );
    992992        }
    993993
     
    10171017                $expected .= "<script type='text/javascript' src='/wp-includes/js/script2.js'></script>\n";
    10181018
    1019                 $this->assertEquals( $expected, get_echo( 'wp_print_scripts' ) );
     1019                $this->assertEqualsIgnoreEOL( $expected, get_echo( 'wp_print_scripts' ) );
    10201020        }
    10211021
Note: See TracChangeset for help on using the changeset viewer.