Changeset 46640

Timestamp:

11/03/2019 08:10:23 PM (5 years ago)

Author:

whyisjake

Message:

Login and Registration: Allow email logins to be more flexible.

Allows a login to have an apostorphe. Which would normally be created as a mistake, but this allows the login to happen.

Fixes #38744
Props wpkuf, desrosj, socalchristina, bibliofille, santilinwp, nsubugak, sncoker, cafenoirdesign, whyisjake.

Location:

trunk

Files:

• src/wp-admin/includes/user.php (modified) (1 diff)
• src/wp-includes/user.php (modified) (1 diff)
• src/wp-login.php (modified) (2 diffs)
• tests/phpunit/tests/user.php (modified) (2 diffs)

trunk/src/wp-admin/includes/user.php

@@ -42 +42 @@
 
     if ( ! $update && isset( $_POST['user_login'] ) ) {
-        $user->user_login = sanitize_user( $_POST['user_login'], true );
+        $user->user_login = sanitize_user( wp_unslash( $_POST['user_login'] ), true );
     }
 

trunk/src/wp-includes/user.php

@@ -36 +36 @@
 
         if ( ! empty( $_POST['log'] ) ) {
-            $credentials['user_login'] = $_POST['log'];
+            $credentials['user_login'] = wp_unslash( $_POST['log'] );
         }
         if ( ! empty( $_POST['pwd'] ) ) {

trunk/src/wp-login.php

@@ -1033 +1033 @@
         if ( $http_post ) {
             if ( isset( $_POST['user_login'] ) && is_string( $_POST['user_login'] ) ) {
-                $user_login = $_POST['user_login'];
+                $user_login = wp_unslash( $_POST['user_login'] );
             }
 
@@ -1151 +1151 @@
         // If the user wants SSL but the session is not SSL, force a secure cookie.
         if ( ! empty( $_POST['log'] ) && ! force_ssl_admin() ) {
-            $user_name = sanitize_user( $_POST['log'] );
+            $user_name = sanitize_user( wp_unslash( $_POST['log'] ) );
             $user      = get_user_by( 'login', $user_name );
 

trunk/tests/phpunit/tests/user.php

@@ -36 +36 @@
         self::$user_ids[] = self::$contrib_id;
 
+        self::$user_ids[] = $factory->user->create(
+            array(
+                'user_login'    => "testemailaddress'@test.com",
+                'user_nicename' => 'user_email_with_apostrophe',
+                'user_pass'     => 'password',
+                'first_name'    => 'John',
+                'last_name'     => 'Doe',
+                'display_name'  => 'John Doe',
+                'user_email'    => "testemailaddress'@test.com",
+                'user_url'      => 'http://tacos.com',
+                'role'          => 'contributor',
+                'nickname'      => 'Johnny',
+                'description'   => 'I am a WordPress user that cares about privacy.',
+            )
+        );
+
         self::$author_id  = $factory->user->create(
             array(
@@ -64 +80 @@
 
         $this->author = clone self::$_author;
+    }
+
+    public function test_that_you_can_login_with_an_email_that_has_apostrophe() {
+
+        //create the user with an email that has an apostrophe (see test setup)
+
+        //login as the user
+        $credentials = [
+            'user_login'    => "testemailaddress'@test.com",
+            'user_password' => 'password',
+        ];
+
+        //attempt to login
+        $user = wp_signon( $credentials );
+
+        //assert that login was successfull
+        //if the login fails, an instance of WP_Error is returned rather than User object
+        $this->assertNotWPError( $user );
     }