Changeset 46657 for trunk/tests/phpunit/tests/rest-api/rest-pages-controller.php

Timestamp:

11/05/2019 08:41:12 PM (7 years ago)

Author:

SergeyBiryukov

Message:

REST API: Speed up pagination unit tests by creating less fixtures and reusing them where possible.

Includes minor documentation and code layout fixes for better readability.

See #30017, #48145.

File:

• trunk/tests/phpunit/tests/rest-api/rest-pages-controller.php (modified) (7 diffs)

trunk/tests/phpunit/tests/rest-api/rest-pages-controller.php

@@ -126 +126 @@
                         )
                 );
-                // No parent
+
+                // No parent.
                 $request  = new WP_REST_Request( 'GET', '/wp/v2/pages' );
                 $response = rest_get_server()->dispatch( $request );
                 $data     = $response->get_data();
                 $this->assertEquals( 2, count( $data ) );
-                // Filter to parent
+
+                // Filter to parent.
                 $request->set_param( 'parent', $id1 );
                 $response = rest_get_server()->dispatch( $request );
@@ -137 +139 @@
                 $this->assertEquals( 1, count( $data ) );
                 $this->assertEquals( $id2, $data[0]['id'] );
-                // Invalid parent should fail
+
+                // Invalid 'parent' should error.
                 $request->set_param( 'parent', 'some-slug' );
                 $response = rest_get_server()->dispatch( $request );
@@ -170 +173 @@
                         )
                 );
-                // No parent
+
+                // No parent.
                 $request  = new WP_REST_Request( 'GET', '/wp/v2/pages' );
                 $response = rest_get_server()->dispatch( $request );
                 $data     = $response->get_data();
                 $this->assertEquals( 4, count( $data ) );
-                // Filter to parents
+
+                // Filter to parents.
                 $request->set_param( 'parent', array( $id1, $id3 ) );
                 $response = rest_get_server()->dispatch( $request );
@@ -197 +202 @@
                         )
                 );
-                // No parent
+
+                // No parent.
                 $request  = new WP_REST_Request( 'GET', '/wp/v2/pages' );
                 $response = rest_get_server()->dispatch( $request );
                 $data     = $response->get_data();
                 $this->assertEquals( 2, count( $data ) );
-                // Filter to parent
+
+                // Filter to parent.
                 $request->set_param( 'parent_exclude', $id1 );
                 $response = rest_get_server()->dispatch( $request );
@@ -208 +215 @@
                 $this->assertEquals( 1, count( $data ) );
                 $this->assertEquals( $id1, $data[0]['id'] );
-                // Invalid parent_exclude should error
+
+                // Invalid 'parent_exclude' should error.
                 $request->set_param( 'parent_exclude', 'some-slug' );
                 $response = rest_get_server()->dispatch( $request );
@@ -242 +250 @@
                         )
                 );
-                // No parent
+
+                // No parent.
                 $request  = new WP_REST_Request( 'GET', '/wp/v2/pages' );
                 $response = rest_get_server()->dispatch( $request );
                 $data     = $response->get_data();
                 $this->assertEqualSets( array( $id1, $id2, $id3, $id4 ), wp_list_pluck( $data, 'id' ) );
-                // Filter to menu_order
+
+                // Filter to 'menu_order'.
                 $request->set_param( 'menu_order', 1 );
                 $response = rest_get_server()->dispatch( $request );
                 $data     = $response->get_data();
                 $this->assertEqualSets( array( $id4 ), wp_list_pluck( $data, 'id' ) );
-                // Order by menu order
+
+                // Order by 'menu order'.
                 $request = new WP_REST_Request( 'GET', '/wp/v2/pages' );
                 $request->set_param( 'order', 'asc' );
@@ -262 +273 @@
                 $this->assertEquals( $id2, $data[2]['id'] );
                 $this->assertEquals( $id3, $data[3]['id'] );
-                // Invalid menu_order should fail
+
+                // Invalid 'menu_order' should error.
                 $request = new WP_REST_Request( 'GET', '/wp/v2/pages' );
                 $request->set_param( 'menu_order', 'top-first' );