Changeset 46709 for trunk/src/wp-admin/credits.php

Timestamp:

11/11/2019 08:43:48 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Help/About: Update the 5.3 About page.

• Remove extra padding on the Credits tab.

Previously [46556], [46572], [46616], [46705].
Props ryelle.
See #47708.

File:

• trunk/src/wp-admin/credits.php (modified) (1 diff)

trunk/src/wp-admin/credits.php

@@ -86 +86 @@
     exit;
 }
+?>
 
-$previous_type = '';
+    <hr />
 
-foreach ( $credits['groups'] as $group_slug => $group_data ) :
-    ?>
-    <?php
-    if ( $previous_type !== $group_data['type'] ) {
-        echo '<hr />';
-    }
-    ?>
     <div class="about__section">
-        <div class="column <?php echo 'titles' === $group_data['type'] ? 'has-subtle-background-color' : ''; ?>">
-
-    <?php
-    if ( $group_data['name'] ) {
-        if ( 'Translators' == $group_data['name'] ) {
-            // Considered a special slug in the API response. (Also, will never be returned for en_US.)
-            $title = _x( 'Translators', 'Translate this to be the equivalent of English Translators in your language for the credits page Translators section' );
-        } elseif ( isset( $group_data['placeholders'] ) ) {
-            // phpcs:ignore WordPress.WP.I18n.LowLevelTranslationFunction,WordPress.WP.I18n.NonSingularStringLiteralText
-            $title = vsprintf( translate( $group_data['name'] ), $group_data['placeholders'] );
-        } else {
-            // phpcs:ignore WordPress.WP.I18n.LowLevelTranslationFunction,WordPress.WP.I18n.NonSingularStringLiteralText
-            $title = translate( $group_data['name'] );
-        }
-
-        echo '<h2 class="wp-people-group-title">' . esc_html( $title ) . "</h2>\n";
-    }
-
-    if ( ! empty( $group_data['shuffle'] ) ) {
-        shuffle( $group_data['data'] ); // We were going to sort by ability to pronounce "hierarchical," but that wouldn't be fair to Matt.
-    }
-
-    switch ( $group_data['type'] ) {
-        case 'list':
-            array_walk( $group_data['data'], '_wp_credits_add_profile_link', $credits['data']['profiles'] );
-            echo '<p class="wp-credits-list">' . wp_sprintf( '%l.', $group_data['data'] ) . "</p>\n\n";
-            break;
-        case 'libraries':
-            array_walk( $group_data['data'], '_wp_credits_build_object_link' );
-            echo '<p class="wp-credits-list">' . wp_sprintf( '%l.', $group_data['data'] ) . "</p>\n\n";
-            break;
-        default:
-            $compact = 'compact' == $group_data['type'];
-            $classes = 'wp-people-group ' . ( $compact ? 'compact' : '' );
-            echo '<ul class="' . $classes . '" id="wp-people-group-' . $group_slug . '">' . "\n";
-            foreach ( $group_data['data'] as $person_data ) {
-                echo '<li class="wp-person" id="wp-person-' . esc_attr( $person_data[2] ) . '">' . "\n\t";
-                echo '<a href="' . esc_url( sprintf( $credits['data']['profiles'], $person_data[2] ) ) . '" class="web">';
-                $size   = 'compact' == $group_data['type'] ? 40 : 80;
-                $data   = get_avatar_data( $person_data[1] . '@md5.gravatar.com', array( 'size' => $size ) );
-                $size  *= 2;
-                $data2x = get_avatar_data( $person_data[1] . '@md5.gravatar.com', array( 'size' => $size ) );
-                echo '<img src="' . esc_url( $data['url'] ) . '" srcset="' . esc_url( $data2x['url'] ) . ' 2x" class="gravatar" alt="" />' . "\n";
-                echo esc_html( $person_data[0] ) . "</a>\n\t";
-                if ( ! $compact ) {
-                    // phpcs:ignore WordPress.WP.I18n.LowLevelTranslationFunction,WordPress.WP.I18n.NonSingularStringLiteralText
-                    echo '<span class="title">' . translate( $person_data[3] ) . "</span>\n";
-                }
-                echo "</li>\n";
-            }
-            echo "</ul>\n";
-            break;
-    }
-    $previous_type = $group_data['type'];
-    ?>
-
+        <div class="column has-subtle-background-color">
+            <?php wp_credits_section_title( $credits['groups']['core-developers'] ); ?>
+            <?php wp_credits_section_list( $credits, 'core-developers' ); ?>
+            <?php wp_credits_section_list( $credits, 'contributing-developers' ); ?>
         </div>
     </div>
-<?php endforeach; ?>
+
+    <hr />
+
+    <div class="about__section">
+        <div class="column">
+            <?php wp_credits_section_title( $credits['groups']['props'] ); ?>
+            <?php wp_credits_section_list( $credits, 'props' ); ?>
+        </div>
+    </div>
+
+    <hr />
+
+    <?php if ( isset( $credits['groups']['translators'] ) || isset( $credits['groups']['validators'] ) ) : ?>
+    <div class="about__section">
+        <div class="column">
+            <?php wp_credits_section_title( $credits['groups']['validators'] ); ?>
+            <?php wp_credits_section_list( $credits, 'validators' ); ?>
+            <?php wp_credits_section_list( $credits, 'translators' ); ?>
+        </div>
+    </div>
+
+    <hr />
+    <?php endif; ?>
+
+    <div class="about__section">
+        <div class="column">
+            <?php wp_credits_section_title( $credits['groups']['libraries'] ); ?>
+            <?php wp_credits_section_list( $credits, 'libraries' ); ?>
+        </div>
+    </div>
 </div>
 <?php