Changeset 46774

Timestamp:

11/25/2019 10:10:31 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Date/Time: Remove mysql2date() usage in get_feed_build_date() to ensure the output includes correct timezone offset.

With the changes in [45908], mysql2date() works correctly for all local time inputs, but should not be used for UTC time inputs.

Add a unit test.

Props Rarst, lisota.
Merges [46756] and [46757] to the 5.3 branch.
Fixes #48675.

Location:

branches/5.3

Files:

• . (modified) (1 prop)
• src/wp-includes/feed.php (modified) (1 diff)
• tests/phpunit/tests/date/getFeedBuildDate.php (copied) (copied from trunk/tests/phpunit/tests/date/getFeedBuildDate.php)

branches/5.3/src/wp-includes/feed.php

@@ -684 +684 @@
 
     // Determine the maximum modified time.
-    $max_modified_time = mysql2date( $format, max( $modified_times ), false );
+    $datetime = date_create_immutable_from_format(
+        'Y-m-d H:i:s',
+        max( $modified_times ),
+        new DateTimeZone( 'UTC' )
+    );
+
+    $max_modified_time = $datetime->format( $format );
 
     /**