Changeset 46780

Timestamp:

11/25/2019 01:44:16 PM (7 years ago)

Author:

SergeyBiryukov

Message:

Options, Meta APIs: Avoid a race condition causing the first of two subsequent requests updating different options at the same time to lose changes.

Every time an autoloaded option is updated or deleted, the alloptions cache is similarly updated. Due to the race condition, on any autoloaded option being updated, every other autoloaded option had its value set to the value at load time, causing a mismatch between the data in the persistent cache and the database.

This change introduces a $force_cache parameter for wp_load_alloptions() to force an update of the local alloptions cache from the persistent cache when an option is added, updated, or deleted, to minimize the chance of affecting other options.

Props fabifott, rmccue, tollmanz, johnjamesjacoby, spacedmonkey, dd32, jipmoors, tellyworth, jeremyclarke, joehoyle, boonebgorges, danielbachhuber, flixos90, jeichorn, mihdan, Grzegorz.Janoszka, SergeyBiryukov.
Merges [46753] and [46779] to the 5.3 branch.
Fixes #31245.

Location:

branches/5.3

Files:

• . (modified) (1 prop)
• src/wp-includes/option.php (modified) (4 diffs)

branches/5.3/src/wp-includes/option.php

@@ -190 +190 @@
  *
  * @since 2.2.0
+ * @since 5.3.1 The `$force_cache` parameter was added.
  *
  * @global wpdb $wpdb WordPress database abstraction object.
  *
+ * @param bool $force_cache Optional. Whether to force an update of the local cache
+ *                          from the persistent cache. Default false.
  * @return array List of all options.
  */
-function wp_load_alloptions() {
+function wp_load_alloptions( $force_cache = false ) {
         global $wpdb;
 
         if ( ! wp_installing() || ! is_multisite() ) {
-                $alloptions = wp_cache_get( 'alloptions', 'options' );
+                $alloptions = wp_cache_get( 'alloptions', 'options', $force_cache );
         } else {
                 $alloptions = false;
@@ -398 +401 @@
 
         if ( ! wp_installing() ) {
-                $alloptions = wp_load_alloptions();
+                $alloptions = wp_load_alloptions( true );
                 if ( isset( $alloptions[ $option ] ) ) {
                         $alloptions[ $option ] = $serialized_value;
@@ -506 +509 @@
         if ( ! wp_installing() ) {
                 if ( 'yes' == $autoload ) {
-                        $alloptions            = wp_load_alloptions();
+                        $alloptions            = wp_load_alloptions( true );
                         $alloptions[ $option ] = $serialized_value;
                         wp_cache_set( 'alloptions', $alloptions, 'options' );
@@ -584 +587 @@
         if ( ! wp_installing() ) {
                 if ( 'yes' == $row->autoload ) {
-                        $alloptions = wp_load_alloptions();
+                        $alloptions = wp_load_alloptions( true );
                         if ( is_array( $alloptions ) && isset( $alloptions[ $option ] ) ) {
                                 unset( $alloptions[ $option ] );