Changeset 46795

Timestamp:

11/28/2019 01:40:19 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Date/Time: Make get_permalink() more resilient against PHP timezone changes.

Overriding default PHP timezone with date_default_timezone_set(), while not recommended, should not inadvertently result in changing existing permalinks.

Add a unit test.

Props Rarst, steevithak, archon810, maciejmackowiak, Ov3rfly, Cybr, hometowntrailers, scvleon, miette49.
Fixes #48623.

Location:

trunk

Files:

• src/wp-includes/link-template.php (modified) (3 diffs)
• tests/phpunit/tests/date/getPermalink.php (added)

trunk/src/wp-includes/link-template.php

@@ -167 +167 @@
 
     if ( '' != $permalink && ! in_array( $post->post_status, array( 'draft', 'pending', 'auto-draft', 'future' ) ) ) {
-        $unixtime = strtotime( $post->post_date );
 
         $category = '';
@@ -213 +212 @@
         }
 
-        $date           = explode( ' ', gmdate( 'Y m d H i s', $unixtime ) );
-        $rewritereplace =
-        array(
+        // This is not an API call because the permalink is based on the stored post_date value,
+        // which should be parsed as local time regardless of the default PHP timezone.
+        $date = explode( ' ', str_replace( array( '-', ':' ), ' ', $post->post_date ) );
+
+        $rewritereplace = array(
             $date[0],
             $date[1],
@@ -228 +229 @@
             $post->post_name,
         );
-        $permalink      = home_url( str_replace( $rewritecode, $rewritereplace, $permalink ) );
-        $permalink      = user_trailingslashit( $permalink, 'single' );
+
+        $permalink = home_url( str_replace( $rewritecode, $rewritereplace, $permalink ) );
+        $permalink = user_trailingslashit( $permalink, 'single' );
+
     } else { // if they're not using the fancy permalink option
         $permalink = home_url( '?p=' . $post->ID );