Changeset 46810

Timestamp:

12/02/2019 02:47:27 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Taxonomy: Remove redundant caching from get_all_category_ids(), deprecated in favor of get_terms() in [28679].

The all_category_ids cache key it relied on was removed in [5555] and never repopulated, causing invalid or unexpected results when using a persistent object cache.

Props itowhid06, johnjamesjacoby.
Fixes #48176.

File:

• trunk/src/wp-includes/deprecated.php (modified) (1 diff)

trunk/src/wp-includes/deprecated.php

@@ -1287 +1287 @@
     _deprecated_function( __FUNCTION__, '4.0.0', 'get_terms()' );
 
-    if ( ! $cat_ids = wp_cache_get( 'all_category_ids', 'category' ) ) {
-        $cat_ids = get_terms(
-            array(
-                'taxonomy' => 'category',
-                'fields'   => 'ids',
-                'get'      => 'all',
-            )
-        );
-        wp_cache_add( 'all_category_ids', $cat_ids, 'category' );
-    }
+    $cat_ids = get_terms(
+        array(
+            'taxonomy' => 'category',
+            'fields'   => 'ids',
+            'get'      => 'all',
+        )
+    );
 
     return $cat_ids;