Changeset 46830 for trunk/tests/phpunit/includes/factory/class-wp-unittest-factory-for-thing.php

Timestamp:

12/09/2019 10:39:39 AM (3 years ago)

Author:

SergeyBiryukov

Message:

Tests: Pad incrementors used in factories with leading zeros to make sure MySQL sorting works as expected.

Previously, tests could create sequential objects with names like Term 99, Term 100, which by default would be returned in reverse order when sorted by name alphabetically, causing seemingly random test failures that are extremely hard to debug.

See #48145.

File:

• trunk/tests/phpunit/includes/factory/class-wp-unittest-factory-for-thing.php (modified) (1 diff)

trunk/tests/phpunit/includes/factory/class-wp-unittest-factory-for-thing.php

@@ -131 +131 @@
 
         // Use the same incrementor for all fields belonging to this object.
-        $gen  = new WP_UnitTest_Generator_Sequence();
-        $incr = $gen->get_incr();
+        $gen = new WP_UnitTest_Generator_Sequence();
+        // Add leading zeros to make sure MySQL sorting works as expected.
+        $incr = zeroise( $gen->get_incr(), 7 );
 
         foreach ( array_keys( $generation_definitions ) as $field_name ) {