Changeset 46843 for branches/5.3/src/wp-admin/includes/class-walker-nav-menu-checklist.php

Timestamp:

12/09/2019 01:48:37 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Accessibility: Menus: Properly disable form controls on the Menus screen that cannot be used until at least one menu is created.

This ensures that the actual UI controls state matches the visually conveyed state.

Props afercia, audrasjb, dinhtungdu, sathyapulse, simonjanin, welcher, SergeyBiryukov.
Merges [46842] to the 5.3 branch.
Fixes #48409.

Location:

branches/5.3

Files:

• . (modified) (1 prop)
• src/wp-admin/includes/class-walker-nav-menu-checklist.php (modified) (3 diffs)

branches/5.3/src/wp-admin/includes/class-walker-nav-menu-checklist.php

@@ -63 +63 @@
      * @since 3.0.0
      *
-     * @global int $_nav_menu_placeholder
+     * @global int        $_nav_menu_placeholder
+     * @global int|string $nav_menu_selected_id
      *
      * @param string $output Used to append additional content (passed by reference).
@@ -72 +73 @@
      */
     public function start_el( &$output, $item, $depth = 0, $args = array(), $id = 0 ) {
-        global $_nav_menu_placeholder;
+        global $_nav_menu_placeholder, $nav_menu_selected_id;
 
         $_nav_menu_placeholder = ( 0 > $_nav_menu_placeholder ) ? intval( $_nav_menu_placeholder ) - 1 : -1;
@@ -82 +83 @@
         $output .= $indent . '<li>';
         $output .= '<label class="menu-item-title">';
-        $output .= '<input type="checkbox" class="menu-item-checkbox';
+        $output .= '<input type="checkbox"' . wp_nav_menu_disabled_check( $nav_menu_selected_id, false ) . ' class="menu-item-checkbox';
 
         if ( ! empty( $item->front_or_home ) ) {