Changeset 46865

Timestamp:

12/09/2019 08:06:37 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Date/Time: XML-RPC: Сalculate the proper offset for GMT in wp.newPost, wp.editComment, mw.newPost, mw.editPost when post_date or comment_date is set.

Previously, post_date or comment_date was assumed to be GMT, which is only true if the timezone string for the site matches GMT.

Add unit tests.

Props Rarst, smerriman, justdaiv, wonderboymusic, noyle.
Merges [46864] to the 5.3 branch.
Fixes #30429.

Location:

branches/5.3

Files:

• . (modified) (1 prop)
• src/wp-includes/class-wp-xmlrpc-server.php (modified) (4 diffs)
• tests/phpunit/tests/date/xmlrpc.php (copied) (copied from trunk/tests/phpunit/tests/date/xmlrpc.php)

branches/5.3/src/wp-includes/class-wp-xmlrpc-server.php

@@ -1470 +1470 @@
 
         if ( ! empty( $dateCreated ) ) {
-            $post_data['post_date']     = get_date_from_gmt( iso8601_to_datetime( $dateCreated ) );
-            $post_data['post_date_gmt'] = iso8601_to_datetime( $dateCreated, 'GMT' );
+            $post_data['post_date']     = iso8601_to_datetime( $dateCreated );
+            $post_data['post_date_gmt'] = iso8601_to_datetime( $dateCreated, 'gmt' );
 
             // Flag the post date to be edited.
@@ -3763 +3763 @@
             // We know this is supposed to be GMT, so we're going to slap that Z on there by force
             $dateCreated                 = rtrim( $content_struct['date_created_gmt']->getIso(), 'Z' ) . 'Z';
-            $comment['comment_date']     = get_date_from_gmt( iso8601_to_datetime( $dateCreated ) );
-            $comment['comment_date_gmt'] = iso8601_to_datetime( $dateCreated, 'GMT' );
+            $comment['comment_date']     = get_date_from_gmt( $dateCreated );
+            $comment['comment_date_gmt'] = iso8601_to_datetime( $dateCreated, 'gmt' );
         }
 
@@ -5482 +5482 @@
 
         if ( ! empty( $dateCreated ) ) {
-            $post_date     = get_date_from_gmt( iso8601_to_datetime( $dateCreated ) );
-            $post_date_gmt = iso8601_to_datetime( $dateCreated, 'GMT' );
+            $post_date     = iso8601_to_datetime( $dateCreated );
+            $post_date_gmt = iso8601_to_datetime( $dateCreated, 'gmt' );
         } else {
             $post_date     = '';
@@ -5871 +5871 @@
 
         if ( ! empty( $dateCreated ) ) {
-            $post_date     = get_date_from_gmt( iso8601_to_datetime( $dateCreated ) );
-            $post_date_gmt = iso8601_to_datetime( $dateCreated, 'GMT' );
+            $post_date     = iso8601_to_datetime( $dateCreated );
+            $post_date_gmt = iso8601_to_datetime( $dateCreated, 'gmt' );
 
             // Flag the post date to be edited.