Changeset 46899 for branches/5.3/src/wp-includes/kses.php

Timestamp:

12/12/2019 06:10:23 PM (5 years ago)

Author:

whyisjake

Message:

Update wp_kses_bad_protocol() to recognize : on uri attributes,

wp_kses_bad_protocol() makes sure to validate that uri attributes don’t contain invalid/or not allowed protocols. While this works fine in most cases, there’s a risk that by using the colon html5 named entity, one is able to bypass this function.

Brings r46895 to the 5.3 branch.

Props: xknown, nickdaugherty, peterwilsoncc.

File:

• branches/5.3/src/wp-includes/kses.php (modified) (1 diff)

branches/5.3/src/wp-includes/kses.php

@@ -1666 +1666 @@
 function wp_kses_bad_protocol_once( $string, $allowed_protocols, $count = 1 ) {
     $string  = preg_replace( '/(&#0*58(?![;0-9])|&#x0*3a(?![;a-f0-9]))/i', '$1;', $string );
-    $string2 = preg_split( '/:|&#0*58;|&#x0*3a;/i', $string, 2 );
+    $string2 = preg_split( '/:|&#0*58;|&#x0*3a;|:/i', $string, 2 );
     if ( isset( $string2[1] ) && ! preg_match( '%/\?%', $string2[0] ) ) {
         $string   = trim( $string2[1] );