Changeset 46917 for branches/4.8/tests/phpunit/tests/kses.php

Timestamp:

12/12/2019 06:53:18 PM (7 years ago)

Author:

SergeyBiryukov

Message:

Ensure that a user can publish_posts before making a post sticky.

Props: danielbachhuber, whyisjake, peterwilson, xknown.

Brings r46893 to the 4.8 branch.

Update wp_kses_bad_protocol() to recognize : on uri attributes,

wp_kses_bad_protocol() makes sure to validate that uri attributes don’t contain invalid/or not allowed protocols. While this works fine in most cases, there’s a risk that by using the colon html5 named entity, one is able to bypass this function.

Brings r46895 to the 4.8 branch.

Props: xknown, nickdaugherty, peterwilsoncc.

Location:

branches/4.8

Files:

• . (modified) (1 prop)
• tests/phpunit/tests/kses.php (modified) (1 diff)

branches/4.8/tests/phpunit/tests/kses.php

@@ -170 +170 @@
                 }
 
+                $bad_not_normalized = array(
+                        'dummy:alert(1)',
+                        'javascript:alert(1)',
+                        'javascript&CoLon;alert(1)',
+                        'javascript:alert(1);',
+                        'javascript:alert(1);',
+                        'javascript:alert(1);',
+                        'javascript&#0000058alert(1);',
+                        'jav    ascript:alert(1);',
+                        'javascript:javascript:alert(1);',
+                        'javascript:javascript:alert(1);',
+                        'javascript&#0000058javascript:alert(1);',
+                        'javascript:javascript&#0000058alert(1);',
+                        'javascript&#58alert(1)',
+                );
+                foreach ( $bad_not_normalized as $k => $x ) {
+                        $result = wp_kses_bad_protocol( $x, wp_allowed_protocols() );
+                        if ( ! empty( $result ) && 'alert(1);' !== $result && 'alert(1)' !== $result ) {
+                                $this->fail( "wp_kses_bad_protocol failed on $k, $x. Result: $result" );
+                        }
+                }
+
                 $safe = array(
                         'dummy:alert(1)',