Changeset 46964

Timestamp:

12/16/2019 12:53:59 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict comparison in wp-admin/widgets.php.

Props jenilk.
Fixes #49000.

File:

• trunk/src/wp-admin/widgets.php (modified) (8 diffs)

trunk/src/wp-admin/widgets.php

@@ -25 +25 @@
     check_admin_referer( 'widgets-access' );
 
-    $widgets_access = 'on' == $_GET['widgets-access'] ? 'on' : 'off';
+    $widgets_access = 'on' === $_GET['widgets-access'] ? 'on' : 'off';
     set_user_setting( 'widgets_access', $widgets_access );
 }
 
-if ( 'on' == $widgets_access ) {
+if ( 'on' === $widgets_access ) {
     add_filter( 'admin_body_class', 'wp_widgets_access_body_class' );
 } else {
@@ -97 +97 @@
 
 foreach ( $sidebars_widgets as $sidebar_id => $widgets ) {
-    if ( 'wp_inactive_widgets' == $sidebar_id ) {
+    if ( 'wp_inactive_widgets' === $sidebar_id ) {
         continue;
     }
@@ -189 +189 @@
 
     foreach ( (array) $wp_registered_widget_updates as $name => $control ) {
-        if ( $name != $id_base || ! is_callable( $control['callback'] ) ) {
+        if ( $name !== $id_base || ! is_callable( $control['callback'] ) ) {
             continue;
         }
@@ -317 +317 @@
     foreach ( $wp_registered_sidebars as $sbname => $sbvalue ) {
         echo "\t\t<tr><td><label><input type='radio' name='sidebar' value='" . esc_attr( $sbname ) . "'" . checked( $sbname, $sidebar, false ) . " /> $sbvalue[name]</label></td><td>";
-        if ( 'wp_inactive_widgets' == $sbname || 'orphaned_widgets' == substr( $sbname, 0, 16 ) ) {
+        if ( 'wp_inactive_widgets' === $sbname || 'orphaned_widgets' === substr( $sbname, 0, 16 ) ) {
             echo '&nbsp;';
         } else {
@@ -457 +457 @@
 $theme_sidebars = array();
 foreach ( $wp_registered_sidebars as $sidebar => $registered_sidebar ) {
-    if ( false !== strpos( $registered_sidebar['class'], 'inactive-sidebar' ) || 'orphaned_widgets' == substr( $sidebar, 0, 16 ) ) {
+    if ( false !== strpos( $registered_sidebar['class'], 'inactive-sidebar' ) || 'orphaned_widgets' === substr( $sidebar, 0, 16 ) ) {
         $wrap_class = 'widgets-holder-wrap';
         if ( ! empty( $registered_sidebar['class'] ) ) {
@@ -463 +463 @@
         }
 
-        $is_inactive_widgets = 'wp_inactive_widgets' == $registered_sidebar['id'];
+        $is_inactive_widgets = 'wp_inactive_widgets' === $registered_sidebar['id'];
         ?>
         <div class="<?php echo esc_attr( $wrap_class ); ?>">
@@ -511 +511 @@
 
 if ( $sidebars_count > 1 ) {
-    $split = ceil( $sidebars_count / 2 );
+    $split = (int) ceil( $sidebars_count / 2 );
 } else {
     $single_sidebar_class = ' single-sidebar';
@@ -532 +532 @@
     }
 
-    if ( $split && $i == $split ) {
+    if ( $split && $i === $split ) {
         ?>
         </div><div class="sidebars-column-2">