Changeset 46977 for branches/5.3/src/wp-includes/post.php

Timestamp:

12/17/2019 08:52:44 PM (6 years ago)

Author:

SergeyBiryukov

Message:

Date/Time: Ensure that get_feed_build_date() correctly handles a modified post object with invalid date.

• Clarify in the documentation that the function returns false on failure.
• Consistently pass the return value through the get_feed_build_date filter.

Props Rarst, dd32, azaozz, tellyworth.
Merges [46974] and [46973] to the 5.3 branch.
Fixes #48957.

Location:

branches/5.3

Files:

• . (modified) (1 prop)
• src/wp-includes/post.php (modified) (5 diffs)

branches/5.3/src/wp-includes/post.php

@@ -6387 +6387 @@
  *                          Default 'server'.
  * @param string $post_type Optional. The post type to check. Default 'any'.
- * @return string The date of the last post.
+ * @return string The date of the last post, or false on failure.
  */
 function get_lastpostdate( $timezone = 'server', $post_type = 'any' ) {
@@ -6395 +6395 @@
      * @since 2.3.0
      *
-     * @param string $date     Date the last post was published.
-     * @param string $timezone Location to use for getting the post published date.
-     *                         See get_lastpostdate() for accepted `$timezone` values.
+     * @param string|false $date     Date the last post was published. False on failure.
+     * @param string       $timezone Location to use for getting the post published date.
+     *                               See get_lastpostdate() for accepted `$timezone` values.
      */
     return apply_filters( 'get_lastpostdate', _get_last_post_time( $timezone, 'date', $post_type ), $timezone );
@@ -6416 +6416 @@
  *                          Default 'server'.
  * @param string $post_type Optional. The post type to check. Default 'any'.
- * @return string The timestamp in 'Y-m-d H:i:s' format.
+ * @return string The timestamp in 'Y-m-d H:i:s' format, or false on failure.
  */
 function get_lastpostmodified( $timezone = 'server', $post_type = 'any' ) {
@@ -6447 +6447 @@
      * @since 2.3.0
      *
-     * @param string $lastpostmodified The most recent time that a post was modified, in 'Y-m-d H:i:s' format.
-     * @param string $timezone         Location to use for getting the post modified date.
-     *                                 See get_lastpostdate() for accepted `$timezone` values.
+     * @param string|false $lastpostmodified The most recent time that a post was modified, in 'Y-m-d H:i:s' format.
+     *                                       False on failure.
+     * @param string       $timezone         Location to use for getting the post modified date.
+     *                                       See get_lastpostdate() for accepted `$timezone` values.
      */
     return apply_filters( 'get_lastpostmodified', $lastpostmodified, $timezone );
@@ -6467 +6468 @@
  * @param string $field     Post field to check. Accepts 'date' or 'modified'.
  * @param string $post_type Optional. The post type to check. Default 'any'.
- * @return string|false The timestamp in 'Y-m-d H:i:s' format, or false on error.
+ * @return string|false The timestamp in 'Y-m-d H:i:s' format, or false on failure.
  */
 function _get_last_post_time( $timezone, $field, $post_type = 'any' ) {