Changeset 46977 for branches/5.3/tests/phpunit/tests/date/getFeedBuildDate.php

Timestamp:

12/17/2019 08:52:44 PM (6 years ago)

Author:

SergeyBiryukov

Message:

Date/Time: Ensure that get_feed_build_date() correctly handles a modified post object with invalid date.

• Clarify in the documentation that the function returns false on failure.
• Consistently pass the return value through the get_feed_build_date filter.

Props Rarst, dd32, azaozz, tellyworth.
Merges [46974] and [46973] to the 5.3 branch.
Fixes #48957.

Location:

branches/5.3

Files:

• . (modified) (1 prop)
• tests/phpunit/tests/date/getFeedBuildDate.php (modified) (1 diff)

branches/5.3/tests/phpunit/tests/date/getFeedBuildDate.php

@@ -37 +37 @@
         $this->assertEquals( '2018-07-23T03:13:23+00:00', get_feed_build_date( DATE_RFC3339 ) );
     }
+
+    /**
+     * Test that get_feed_build_date() works with invalid post dates.
+     *
+     * @ticket 48957
+     */
+    public function test_should_fall_back_to_last_post_modified() {
+        global $wp_query;
+
+        update_option( 'timezone_string', 'Europe/Kiev' );
+        $datetime     = new DateTimeImmutable( 'now', wp_timezone() );
+        $datetime_utc = $datetime->setTimezone( new DateTimeZone( 'UTC' ) );
+
+        $wp_query->posts = array();
+
+        $this->assertFalse( get_feed_build_date( DATE_RFC3339 ), 'False when unable to determine valid time' );
+
+        $this->factory->post->create(
+            array(
+                'post_date' => $datetime->format( 'Y-m-d H:i:s' ),
+            )
+        );
+
+        $this->assertEquals(
+            $datetime_utc->format( DATE_RFC3339 ),
+            get_feed_build_date( DATE_RFC3339 ),
+            'Fall back to time of last post modified with no posts'
+        );
+
+        $post_id_broken = $this->factory->post->create();
+        $post_broken    = get_post( $post_id_broken );
+
+        $post_broken->post_modified_gmt = 0;
+
+        $wp_query->posts = array( $post_broken );
+
+        $this->assertEquals(
+            $datetime_utc->format( DATE_RFC3339 ),
+            get_feed_build_date( DATE_RFC3339 ),
+            'Fall back to time of last post modified with broken post object'
+        );
+    }
 }