Changeset 46996 for trunk

Timestamp:

12/19/2019 03:43:33 PM (7 years ago)

Author:

SergeyBiryukov

Message:

Tests: In test_readme(), if the HTTP request to secure.php.net or dev.mysql.com failed, include response code in the error message.

See #40533, #44613.

File:

• trunk/tests/phpunit/tests/external-http/basic.php (modified) (2 diffs)

trunk/tests/phpunit/tests/external-http/basic.php

@@ -17 +17 @@
                 $this->skipTestOnTimeout( $response );
 
-                if ( 200 !== wp_remote_retrieve_response_code( $response ) ) {
-                        $this->fail( 'Could not contact PHP.net to check versions.' );
+                $response_code = wp_remote_retrieve_response_code( $response );
+                if ( 200 !== $response_code ) {
+                        $this->fail( sprintf( 'Could not contact PHP.net to check versions. Response code: %s', $response_code ) );
                 }
 
@@ -33 +34 @@
                 $this->skipTestOnTimeout( $response );
 
-                if ( 200 !== wp_remote_retrieve_response_code( $response ) ) {
-                        $this->fail( 'Could not contact dev.MySQL.com to check versions.' );
+                $response_code = wp_remote_retrieve_response_code( $response );
+                if ( 200 !== $response_code ) {
+                        $this->fail( sprintf( 'Could not contact dev.MySQL.com to check versions. Response code: %s', $response_code ) );
                 }