Changeset 47027

Timestamp:

01/02/2020 11:35:55 AM (6 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict comparison and Yoda conditions in wp-includes/widgets.php.

Props jenilk.
Fixes #49104.

File:

• trunk/src/wp-includes/widgets.php (modified) (9 diffs)

trunk/src/wp-includes/widgets.php

@@ -675 +675 @@
         $index = sanitize_title( $index );
         foreach ( (array) $wp_registered_sidebars as $key => $value ) {
-            if ( sanitize_title( $value['name'] ) == $index ) {
+            if ( sanitize_title( $value['name'] ) === $index ) {
                 $index = $key;
                 break;
@@ -877 +877 @@
             if ( is_array( $widgets ) ) {
                 foreach ( $widgets as $widget ) {
-                    if ( ( $callback && isset( $wp_registered_widgets[ $widget ]['callback'] ) && $wp_registered_widgets[ $widget ]['callback'] == $callback ) || ( $id_base && _get_widget_id_base( $widget ) == $id_base ) ) {
-                        if ( ! $widget_id || $widget_id == $wp_registered_widgets[ $widget ]['id'] ) {
+                    if ( ( $callback && isset( $wp_registered_widgets[ $widget ]['callback'] ) && $wp_registered_widgets[ $widget ]['callback'] === $callback ) || ( $id_base && _get_widget_id_base( $widget ) === $id_base ) ) {
+                        if ( ! $widget_id || $widget_id === $wp_registered_widgets[ $widget ]['id'] ) {
                             return $sidebar;
                         }
@@ -967 +967 @@
  */
 function wp_get_sidebars_widgets( $deprecated = true ) {
-    if ( $deprecated !== true ) {
+    if ( true !== $deprecated ) {
         _deprecated_argument( __FUNCTION__, '2.8.1' );
     }
@@ -1063 +1063 @@
     } else {
         foreach ( array_keys( $settings ) as $number ) {
-            if ( 'number' == $number ) {
+            if ( 'number' === $number ) {
                 continue;
             }
@@ -1089 +1089 @@
             if ( is_array( $sidebar ) ) {
                 foreach ( $sidebar as $i => $name ) {
-                    if ( $base_name == $name ) {
+                    if ( $base_name === $name ) {
                         $sidebars_widgets[ $index ][ $i ] = "$name-2";
                         $changed                          = true;
@@ -1528 +1528 @@
     foreach ( $rss->get_items( 0, $items ) as $item ) {
         $link = $item->get_link();
-        while ( stristr( $link, 'http' ) != $link ) {
+        while ( stristr( $link, 'http' ) !== $link ) {
             $link = substr( $link, 1 );
         }
@@ -1546 +1546 @@
 
             // Change existing [...] to […].
-            if ( '[...]' == substr( $summary, -5 ) ) {
+            if ( '[...]' === substr( $summary, -5 ) ) {
                 $summary = substr( $summary, 0, -5 ) . '[…]';
             }
@@ -1571 +1571 @@
         }
 
-        if ( $link == '' ) {
+        if ( '' === $link ) {
             echo "<li>$title{$date}{$summary}{$author}</li>";
         } elseif ( $show_summary ) {
@@ -1696 +1696 @@
         } else {
             $link = esc_url( strip_tags( $rss->get_permalink() ) );
-            while ( stristr( $link, 'http' ) != $link ) {
+            while ( stristr( $link, 'http' ) !== $link ) {
                 $link = substr( $link, 1 );
             }