Changeset 47036

Timestamp:

01/03/2020 06:42:09 PM (5 years ago)

Author:

kadamwhite

Message:

REST API: Short-circuit comment controller permissions check if commented-upon post type does not exist.

Props imani3011, dragosh635, subrataemfluence, timothyblynjacobs.
Fixes #42238.

Location:

trunk

Files:

• src/wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php (modified) (1 diff)
• tests/phpunit/tests/rest-api/rest-comments-controller.php (modified) (1 diff)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php

@@ -1593 +1593 @@
      */
     protected function check_read_post_permission( $post, $request ) {
-        $post_type        = get_post_type_object( $post->post_type );
+        $post_type = get_post_type_object( $post->post_type );
+
+        // Return false if custom post type doesn't exist
+        if ( ! $post_type ) {
+            return false;
+        }
+
         $posts_controller = $post_type->get_rest_controller();
 

trunk/tests/phpunit/tests/rest-api/rest-comments-controller.php

@@ -3241 +3241 @@
         }
     }
+
+    /**
+     * @ticket 42238
+     */
+    public function test_check_read_post_permission_with_invalid_post_type() {
+        register_post_type(
+            'bug-post',
+            array(
+                'label'        => 'Bug Posts',
+                'supports'     => array( 'title', 'editor', 'author', 'comments' ),
+                'show_in_rest' => true,
+                'public'       => true,
+            )
+        );
+        create_initial_rest_routes();
+
+        $post_id    = self::factory()->post->create( array( 'post_type' => 'bug-post' ) );
+        $comment_id = self::factory()->comment->create( array( 'comment_post_ID' => $post_id ) );
+        _unregister_post_type( 'bug-post' );
+
+        $this->setExpectedIncorrectUsage( 'map_meta_cap' );
+
+        wp_set_current_user( self::$admin_id );
+        $request  = new WP_REST_Request( 'GET', '/wp/v2/comments/' . $comment_id );
+        $response = rest_get_server()->dispatch( $request );
+        $this->assertEquals( 403, $response->get_status() );
+    }
 }