Changeset 47036 for trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php

Timestamp:

01/03/2020 06:42:09 PM (5 years ago)

Author:

kadamwhite

Message:

REST API: Short-circuit comment controller permissions check if commented-upon post type does not exist.

Props imani3011, dragosh635, subrataemfluence, timothyblynjacobs.
Fixes #42238.

File:

• trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php (modified) (1 diff)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php

@@ -1593 +1593 @@
      */
     protected function check_read_post_permission( $post, $request ) {
-        $post_type        = get_post_type_object( $post->post_type );
+        $post_type = get_post_type_object( $post->post_type );
+
+        // Return false if custom post type doesn't exist
+        if ( ! $post_type ) {
+            return false;
+        }
+
         $posts_controller = $post_type->get_rest_controller();