Changeset 47048

Timestamp:

01/07/2020 03:26:44 PM (5 years ago)

Author:

gziolo

Message:

Build Tools: do not include assets for JS dependencies that do not exist.

This is a follow-up for #48154, where we started including *.asset.php files to declare package dependencies.
This works well but creates warnings in environments where the package does not exist because WordPress was not fully built.

Props jeherve, swissspidy.

Fixes #49144.

File:

• trunk/src/wp-includes/script-loader.php (modified) (1 diff)

trunk/src/wp-includes/script-loader.php

@@ -286 +286 @@
 
     foreach ( $packages as $package ) {
-        $handle       = 'wp-' . $package;
-        $path         = "/wp-includes/js/dist/$package$suffix.js";
-        $asset_file   = include( ABSPATH . WPINC . "/assets/dist/$package$suffix.asset.php" );
+        $handle = 'wp-' . $package;
+        $path   = "/wp-includes/js/dist/$package$suffix.js";
+
+        if ( ! file_exists( ABSPATH . $path ) ) {
+            continue;
+        }
+
+        $asset_file   = include ABSPATH . WPINC . "/assets/dist/$package$suffix.asset.php";
         $dependencies = $asset_file['dependencies'];