Changeset 47069

Timestamp:

01/13/2020 05:25:26 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Site Health: Avoid "Undefined property" PHP notices in wp_dashboard_site_health() when the status result transient does not exist yet.

Props dlh for initial patch.
See #47606.

File:

• trunk/src/wp-admin/includes/dashboard.php (modified) (3 diffs)

trunk/src/wp-admin/includes/dashboard.php

@@ -1773 +1773 @@
     $get_issues = get_transient( 'health-check-site-status-result' );
 
-    $issue_counts = new stdClass();
+    $issue_counts = array();
 
     if ( false !== $get_issues ) {
-        $issue_counts = json_decode( $get_issues );
-    }
-
-    if ( ! is_object( $issue_counts ) || empty( $issue_counts ) ) {
-        $issue_counts = (object) array(
+        $issue_counts = json_decode( $get_issues, true );
+    }
+
+    if ( ! is_array( $issue_counts ) || ! $issue_counts ) {
+        $issue_counts = array(
             'good'        => 0,
             'recommended' => 0,
@@ -1787 +1787 @@
     }
 
-    $issues_total = $issue_counts->recommended + $issue_counts->critical;
+    $issues_total = $issue_counts['recommended'] + $issue_counts['critical'];
     ?>
     <div class="health-check-title-section site-health-progress-wrapper loading hide-if-no-js">
@@ -1822 +1822 @@
     <?php else : ?>
         <p>
-            <?php if ( $issue_counts->critical > 0 ) : ?>
+            <?php if ( $issue_counts['critical'] > 0 ) : ?>
                 <?php _e( 'Your site has critical issues that should be addressed as soon as possible to improve the performance or security of your website.' ); ?>
             <?php elseif ( $issues_total <= 0 ) : ?>