Changeset 47118

Timestamp:

01/28/2020 12:51:42 AM (7 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Disable WPCS warnings for date_default_timezone_set() and current_time( 'timestamp' ) calls in Date/Time tests.

These calls are intentional and required for the tests.

See #49222.

Location:

trunk/tests/phpunit/tests

Files:

• date/currentTime.php (modified) (4 diffs)
• date/getPermalink.php (modified) (3 diffs)
• date/mysql2date.php (modified) (2 diffs)
• rest-api/rest-categories-controller.php (modified) (1 diff)

trunk/tests/phpunit/tests/date/currentTime.php

@@ -44 +44 @@
                 $wp_timestamp = $timestamp + 6 * HOUR_IN_SECONDS;
 
+                // phpcs:ignore WordPress.DateTime.CurrentTimeTimestamp.RequestedUTC
                 $this->assertEquals( $timestamp, current_time( 'timestamp', true ), 'The dates should be equal', 2 );
+                // phpcs:ignore WordPress.DateTime.CurrentTimeTimestamp.Requested
                 $this->assertEquals( $wp_timestamp, current_time( 'timestamp' ), 'The dates should be equal', 2 );
         }
@@ -57 +59 @@
                 $datetime = new DateTime( 'now', new DateTimeZone( $timezone_string ) );
 
+                // phpcs:ignore WordPress.DateTime.RestrictedFunctions.timezone_change_date_default_timezone_set
                 date_default_timezone_set( $timezone_string );
 
@@ -62 +65 @@
                 $current_time_custom_timezone     = current_time( $format );
 
+                // phpcs:ignore WordPress.DateTime.RestrictedFunctions.timezone_change_date_default_timezone_set
                 date_default_timezone_set( 'UTC' );
 
@@ -84 +88 @@
                 $wp_timestamp = $timestamp + $datetime->getOffset();
 
+                // phpcs:ignore WordPress.DateTime.CurrentTimeTimestamp.RequestedUTC
                 $this->assertEquals( $timestamp, current_time( 'timestamp', true ), 'The dates should be equal', 2 );
+                // phpcs:ignore WordPress.DateTime.CurrentTimeTimestamp.RequestedUTC
                 $this->assertEquals( $timestamp, current_time( 'U', true ), 'The dates should be equal', 2 );
 
+                // phpcs:ignore WordPress.DateTime.CurrentTimeTimestamp.Requested
                 $this->assertEquals( $wp_timestamp, current_time( 'timestamp' ), 'The dates should be equal', 2 );
+                // phpcs:ignore WordPress.DateTime.CurrentTimeTimestamp.Requested
                 $this->assertEquals( $wp_timestamp, current_time( 'U' ), 'The dates should be equal', 2 );
 
+                // phpcs:ignore WordPress.DateTime.CurrentTimeTimestamp.Requested
                 $this->assertInternalType( 'int', current_time( 'timestamp' ) );
         }

trunk/tests/phpunit/tests/date/getPermalink.php

@@ -11 +11 @@
                 delete_option( 'permalink_structure' );
                 update_option( 'timezone_string', 'UTC' );
+                // phpcs:ignore WordPress.DateTime.RestrictedFunctions.timezone_change_date_default_timezone_set
                 date_default_timezone_set( 'UTC' );
 
@@ -23 +24 @@
                 update_option( 'timezone_string', $timezone );
                 update_option( 'permalink_structure', '/%year%/%monthnum%/%day%/%hour%/%minute%/%second%' );
+                // phpcs:ignore WordPress.DateTime.RestrictedFunctions.timezone_change_date_default_timezone_set
                 date_default_timezone_set( 'UTC' );
 
@@ -34 +36 @@
                 $this->assertEquals( 'http://example.org/2018/07/22/21/13/23', get_permalink( $post_id ) );
 
+                // phpcs:ignore WordPress.DateTime.RestrictedFunctions.timezone_change_date_default_timezone_set
                 date_default_timezone_set( $timezone );
                 $this->assertEquals( 'http://example.org/2018/07/22/21/13/23', get_permalink( $post_id ) );

trunk/tests/phpunit/tests/date/mysql2date.php

@@ -8 +8 @@
 
         function tearDown() {
+                // phpcs:ignore WordPress.DateTime.RestrictedFunctions.timezone_change_date_default_timezone_set
                 date_default_timezone_set( 'UTC' );
 
@@ -32 +33 @@
         function test_mysql2date_should_format_time_with_changed_time_zone() {
                 $timezone = 'Europe/Kiev';
+                // phpcs:ignore WordPress.DateTime.RestrictedFunctions.timezone_change_date_default_timezone_set
                 date_default_timezone_set( $timezone );
                 update_option( 'timezone_string', $timezone );

trunk/tests/phpunit/tests/rest-api/rest-categories-controller.php

@@ -999 +999 @@
                         'id',
                         $this->factory->category->create(
-                                [
+                                array(
                                         'parent' => $old_parent_term->term_id,
-                                ]
+                                )
                         ),
                         'category'