Changeset 47138 for trunk/src/wp-includes/rest-api/class-wp-rest-server.php

Timestamp:

01/30/2020 08:20:30 PM (5 years ago)

Author:

kadamwhite

Message:

REST API: Reuse previously-generated embedded objects when building collection response.

Store each generated embedded object in a temporary cache when querying for linked resources so that repeated links to the same resource do not trigger repeated queries or processing.

Props TimothyBlynJacobs.
Fixes #48838.

File:

• trunk/src/wp-includes/rest-api/class-wp-rest-server.php (modified) (4 diffs)

trunk/src/wp-includes/rest-api/class-wp-rest-server.php

@@ -78 +78 @@
      */
     protected $route_options = array();
+
+    /**
+     * Caches embedded requests.
+     *
+     * @since 5.4.0
+     * @var array
+     */
+    protected $embed_cache = array();
 
     /**
@@ -463 +471 @@
 
         if ( $embed ) {
+            $this->embed_cache = array();
             // Determine if this is a numeric array.
             if ( wp_is_numeric_array( $data ) ) {
@@ -469 +478 @@
                 $data = $this->embed_links( $data );
             }
+            $this->embed_cache = array();
         }
 
@@ -589 +599 @@
                 }
 
-                // Run through our internal routing and serve.
-                $request = WP_REST_Request::from_url( $item['href'] );
-                if ( ! $request ) {
-                    $embeds[] = array();
-                    continue;
-                }
-
-                // Embedded resources get passed context=embed.
-                if ( empty( $request['context'] ) ) {
-                    $request['context'] = 'embed';
-                }
-
-                $response = $this->dispatch( $request );
-
-                /** This filter is documented in wp-includes/rest-api/class-wp-rest-server.php */
-                $response = apply_filters( 'rest_post_dispatch', rest_ensure_response( $response ), $this, $request );
-
-                $embeds[] = $this->response_to_data( $response, false );
+                if ( ! array_key_exists( $item['href'], $this->embed_cache ) ) {
+                    // Run through our internal routing and serve.
+                    $request = WP_REST_Request::from_url( $item['href'] );
+                    if ( ! $request ) {
+                        $embeds[] = array();
+                        continue;
+                    }
+
+                    // Embedded resources get passed context=embed.
+                    if ( empty( $request['context'] ) ) {
+                        $request['context'] = 'embed';
+                    }
+
+                    $response = $this->dispatch( $request );
+
+                    /** This filter is documented in wp-includes/rest-api/class-wp-rest-server.php */
+                    $response = apply_filters( 'rest_post_dispatch', rest_ensure_response( $response ), $this, $request );
+
+                    $this->embed_cache[ $item['href'] ] = $this->response_to_data( $response, false );
+                }
+
+                $embeds[] = $this->embed_cache[ $item['href'] ];
             }