Changeset 47149

Timestamp:

02/01/2020 12:37:14 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Site Health: Rename WP_Site_Health::initialize() introduced in [47063] to ::get_instance(), for clarity and consistency with other core classes.

Use WP_Site_Health::get_instance() where it's needed, instead of creating multiple instances of the class.

Props afercia, xkon, Clorith, SergeyBiryukov.
See #47606.

Location:

trunk/src

Files:

• wp-admin/includes/ajax-actions.php (modified) (4 diffs)
• wp-admin/includes/class-wp-site-health.php (modified) (1 diff)
• wp-admin/includes/dashboard.php (modified) (1 diff)
• wp-admin/site-health-info.php (modified) (1 diff)
• wp-admin/site-health.php (modified) (1 diff)
• wp-settings.php (modified) (1 diff)

trunk/src/wp-admin/includes/ajax-actions.php

@@ -5123 +5123 @@
     }
 
-    $site_health = new WP_Site_Health();
+    $site_health = WP_Site_Health::get_instance();
     wp_send_json_success( $site_health->get_test_dotorg_communication() );
 }
@@ -5143 +5143 @@
     }
 
-    $site_health = new WP_Site_Health();
+    $site_health = WP_Site_Health::get_instance();
     wp_send_json_success( $site_health->get_test_is_in_debug_mode() );
 }
@@ -5163 +5163 @@
     }
 
-    $site_health = new WP_Site_Health();
+    $site_health = WP_Site_Health::get_instance();
     wp_send_json_success( $site_health->get_test_background_updates() );
 }
@@ -5184 +5184 @@
     }
 
-    $site_health = new WP_Site_Health();
+    $site_health = WP_Site_Health::get_instance();
     wp_send_json_success( $site_health->get_test_loopback_requests() );
 }

trunk/src/wp-admin/includes/class-wp-site-health.php

@@ -57 +57 @@
      * @return WP_Site_Health|null
      */
-    public static function initialize() {
+    public static function get_instance() {
         if ( null === self::$instance ) {
             self::$instance = new WP_Site_Health();

trunk/src/wp-admin/includes/dashboard.php

@@ -49 +49 @@
         }
 
-        WP_Site_Health::initialize();
+        WP_Site_Health::get_instance();
 
         wp_enqueue_style( 'site-health' );

trunk/src/wp-admin/site-health-info.php

@@ -26 +26 @@
 }
 
-$health_check_site_status = new WP_Site_Health();
+$health_check_site_status = WP_Site_Health::get_instance();
 
 require_once( ABSPATH . 'wp-admin/admin-header.php' );

trunk/src/wp-admin/site-health.php

@@ -28 +28 @@
 }
 
-$health_check_site_status = new WP_Site_Health();
+$health_check_site_status = WP_Site_Health::get_instance();
 
 // Start by checking if this is a special request checking for the existence of certain filters.

trunk/src/wp-settings.php

@@ -356 +356 @@
     require_once( ABSPATH . 'wp-admin/includes/class-wp-site-health.php' );
 }
-WP_Site_Health::initialize();
+WP_Site_Health::get_instance();
 
 // Load active plugins.