Changeset 47158

Timestamp:

02/01/2020 10:40:06 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Administration: Include options page name in the "Options page not found" error message to provide better context for plugin developers.

Props tdlewis77, williampatton.
Fixes #42941.

File:

• trunk/src/wp-admin/options.php (modified) (3 diffs)

trunk/src/wp-admin/options.php

@@ -201 +201 @@
  * @since 2.7.0
  *
- * @param array $whitelist_options Whitelist options.
+ * @param array $whitelist_options The options whitelist.
  */
 $whitelist_options = apply_filters( 'whitelist_options', $whitelist_options );
@@ -218 +218 @@
 
     if ( ! isset( $whitelist_options[ $option_page ] ) ) {
-        wp_die( __( '<strong>Error</strong>: Options page not found.' ) );
+        wp_die(
+            sprintf(
+                /* translators: %s: The options page name. */
+                __( '<strong>Error</strong>: Options page %s not found in the options whitelist.' ),
+                '<code>' . esc_html( $option_page ) . '</code>'
+            )
+        );
     }
 
@@ -269 +275 @@
                         /* translators: %s: The option/setting. */
                         __( 'The %s setting is unregistered. Unregistered settings are deprecated. See https://developer.wordpress.org/plugins/settings/settings-api/' ),
-                        '<code>' . $option . '</code>'
+                        '<code>' . esc_html( $option ) . '</code>'
                     )
                 );