Changeset 47160

Timestamp:

02/02/2020 03:06:31 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Post Thumbnails: Make sure get_post_thumbnail_id() returns an integer, to match the documented return value.

This makes the function more consistent with get_the_ID() or wp_get_post_parent_id(), both returning an integer.

Props 0v3rth3d4wn.
Fixes #40096.

Location:

trunk

Files:

• src/wp-includes/post-thumbnail-template.php (modified) (2 diffs)
• tests/phpunit/tests/customize/manager.php (modified) (1 diff)

trunk/src/wp-includes/post-thumbnail-template.php

@@ -46 +46 @@
  *
  * @param int|WP_Post $post Optional. Post ID or WP_Post object. Default is global `$post`.
- * @return string|int Post thumbnail ID or empty string.
+ * @return int|string Post thumbnail ID or empty string if the post does not exist.
  */
 function get_post_thumbnail_id( $post = null ) {
@@ -53 +53 @@
         return '';
     }
-    return get_post_meta( $post->ID, '_thumbnail_id', true );
+    return (int) get_post_meta( $post->ID, '_thumbnail_id', true );
 }
 

trunk/tests/phpunit/tests/customize/manager.php

@@ -712 +712 @@
         $this->assertEquals( '', get_page_template_slug( $posts_by_name['blog'] ) );
         $this->assertEquals( $posts_by_name['waffles'], get_post_thumbnail_id( $posts_by_name['custom'] ) );
-        $this->assertEquals( '', get_post_thumbnail_id( $posts_by_name['blog'] ) );
+        $this->assertEquals( 0, get_post_thumbnail_id( $posts_by_name['blog'] ) );
         $attachment_metadata = wp_get_attachment_metadata( $posts_by_name['waffles'] );
         $this->assertEquals( 'Waffles', get_post( $posts_by_name['waffles'] )->post_title );