Changeset 47181 for trunk/tests/phpunit/tests/query/postStatus.php

Timestamp:

02/05/2020 01:31:38 AM (7 years ago)

Author:

SergeyBiryukov

Message:

Posts, Post Types: Fail gracefully when checking whether a single post with an unregistered post status should be displayed in WP_Query::get_posts().

If the post status is not registered, assume it's not public, but still allow access to users with edit permissions (same as for a protected post status, e.g. draft), so that they could recover orphaned content.

Add unit tests.

Follow-up to [47178].

Props roytanck, SergeyBiryukov.
Fixes #48653.

File:

• trunk/tests/phpunit/tests/query/postStatus.php (modified) (2 diffs)

trunk/tests/phpunit/tests/query/postStatus.php

@@ -263 +263 @@
         }
 
+        public function test_single_post_with_nonpublic_status_should_not_be_shown_for_any_user() {
+                register_post_type( 'foo_pt' );
+                register_post_status( 'foo_ps', array( 'public' => false ) );
+                $p = self::factory()->post->create(
+                        array(
+                                'post_status' => 'foo_ps',
+                                'post_author' => self::$author_user_id,
+                        )
+                );
+
+                wp_set_current_user( self::$editor_user_id );
+
+                $q = new WP_Query(
+                        array(
+                                'p' => $p,
+                        )
+                );
+
+                $this->assertEmpty( $q->posts );
+        }
+
         public function test_single_post_with_nonpublic_and_protected_status_should_not_be_shown_for_user_who_cannot_edit_others_posts() {
                 register_post_type( 'foo_pt' );
@@ -371 +392 @@
         }
 
-        public function test_single_post_with_nonpublic_and_protected_status_should_not_be_shown_for_any_user() {
-                register_post_type( 'foo_pt' );
-                register_post_status( 'foo_ps', array( 'public' => false ) );
-                $p = self::factory()->post->create(
-                        array(
-                                'post_status' => 'foo_ps',
-                                'post_author' => self::$author_user_id,
-                        )
-                );
-
-                wp_set_current_user( self::$editor_user_id );
-
-                $q = new WP_Query(
-                        array(
-                                'p' => $p,
-                        )
-                );
-
-                $this->assertEmpty( $q->posts );
+        /**
+         * @ticket 48653
+         */
+        public function test_single_post_with_nonexisting_status_should_not_be_shown_for_user_who_cannot_edit_others_posts() {
+                register_post_type( 'foo_pt' );
+                register_post_status( 'foo_ps', array( 'public' => true ) );
+                $p = self::factory()->post->create(
+                        array(
+                                'post_status' => 'foo_ps',
+                                'post_author' => self::$editor_user_id,
+                        )
+                );
+                _unregister_post_status( 'foo_ps' );
+
+                wp_set_current_user( self::$author_user_id );
+
+                $q = new WP_Query(
+                        array(
+                                'p' => $p,
+                        )
+                );
+
+                $this->assertEmpty( $q->posts );
+        }
+
+        /**
+         * @ticket 48653
+         */
+        public function test_single_post_with_nonexisting_status_should_be_shown_for_user_who_can_edit_others_posts() {
+                register_post_type( 'foo_pt' );
+                register_post_status( 'foo_ps', array( 'public' => true ) );
+                $p = self::factory()->post->create(
+                        array(
+                                'post_status' => 'foo_ps',
+                                'post_author' => self::$author_user_id,
+                        )
+                );
+                _unregister_post_status( 'foo_ps' );
+
+                wp_set_current_user( self::$editor_user_id );
+
+                $q = new WP_Query(
+                        array(
+                                'p' => $p,
+                        )
+                );
+
+                $this->assertEquals( array( $p ), wp_list_pluck( $q->posts, 'ID' ) );
         }