Changeset 47183

Timestamp:

02/05/2020 03:28:33 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Tests: Allow wpdb::set_sql_mode() tests to run on MySQL 8.0.11+.

MySQL 8.0.11 removed support for the NO_AUTO_CREATE_USER SQL mode, which was used in as an example of a mode compatible with WordPress.

NO_AUTO_VALUE_ON_ZERO is now used in the affected tests instead, which is supported on both MySQL 5.7.x and 8.0.x.

Props kaggdesign, jeremyfelt, afragen.
Fixes #44586. See #49344.

File:

• trunk/tests/phpunit/tests/db.php (modified) (3 diffs)

trunk/tests/phpunit/tests/db.php

@@ -296 +296 @@
         $current_modes = $wpdb->get_var( 'SELECT @@SESSION.sql_mode;' );
 
-        $new_modes = array( 'IGNORE_SPACE', 'NO_AUTO_CREATE_USER' );
+        $new_modes = array( 'IGNORE_SPACE', 'NO_AUTO_VALUE_ON_ZERO' );
 
         $wpdb->set_sql_mode( $new_modes );
@@ -316 +316 @@
         $current_modes = $wpdb->get_var( 'SELECT @@SESSION.sql_mode;' );
 
-        $new_modes = array( 'IGNORE_SPACE', 'NO_ZERO_DATE', 'NO_AUTO_CREATE_USER' );
+        $new_modes = array( 'IGNORE_SPACE', 'NO_ZERO_DATE', 'NO_AUTO_VALUE_ON_ZERO' );
         $wpdb->set_sql_mode( $new_modes );
         $check_new_modes = $wpdb->get_var( 'SELECT @@SESSION.sql_mode;' );
@@ -334 +334 @@
         $current_modes = $wpdb->get_var( 'SELECT @@SESSION.sql_mode;' );
 
-        $new_modes = array( 'IGNORE_SPACE', 'ONLY_FULL_GROUP_BY', 'NO_AUTO_CREATE_USER' );
+        $new_modes = array( 'IGNORE_SPACE', 'ONLY_FULL_GROUP_BY', 'NO_AUTO_VALUE_ON_ZERO' );
 
         add_filter( 'incompatible_sql_modes', array( $this, 'filter_allowed_incompatible_sql_mode' ), 1, 1 );