Changeset 47186

Timestamp:

02/05/2020 06:24:16 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Taxonomy: In register_taxonomy(), return the registered taxonomy object on success, for consistency with register_post_type().

Props krynes, SergeyBiryukov.
Fixes #48558.

Location:

trunk

Files:

• src/wp-includes/taxonomy.php (modified) (2 diffs)
• tests/phpunit/tests/post/types.php (modified) (1 diff)
• tests/phpunit/tests/taxonomy.php (modified) (1 diff)

trunk/src/wp-includes/taxonomy.php

@@ -409 +409 @@
  *                                                Default false.
  * }
- * @return void|WP_Error Void on success, WP_Error object on failure.
+ * @return WP_Taxonomy|WP_Error The registered taxonomy object on success, WP_Error object on failure.
  */
 function register_taxonomy( $taxonomy, $object_type, $args = array() ) {
@@ -442 +442 @@
      */
     do_action( 'registered_taxonomy', $taxonomy, $object_type, (array) $taxonomy_object );
+
+    return $taxonomy_object;
 }
 

trunk/tests/phpunit/tests/post/types.php

@@ -38 +38 @@
 
         _unregister_post_type( 'foo' );
+    }
+
+    /**
+     * @ticket 48558
+     */
+    function test_register_post_type_return_value() {
+        $this->assertInstanceOf( 'WP_Post_Type', register_post_type( 'foo' ) );
     }
 

trunk/tests/phpunit/tests/taxonomy.php

@@ -171 +171 @@
 
     /**
+     * @ticket 48558
+     */
+    function test_register_taxonomy_return_value() {
+        $this->assertInstanceOf( 'WP_Taxonomy', register_taxonomy( 'foo', 'post' ) );
+    }
+
+    /**
      * @ticket 21593
      *