Changeset 47196

Timestamp:

02/05/2020 10:38:11 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Posts, Post Types: Add default menu_icon values for built-in post types.

This allows the icons to be retrieved via get_post_type_object().

Props m.usama.masood, michael.ecklund, SergeyBiryukov.
Fixes #38844.

Location:

trunk

Files:

• src/wp-includes/post.php (modified) (3 diffs)
• tests/phpunit/tests/post/types.php (modified) (1 diff)

trunk/src/wp-includes/post.php

@@ -31 +31 @@
             'map_meta_cap'          => true,
             'menu_position'         => 5,
+            'menu_icon'             => 'dashicons-admin-post',
             'hierarchical'          => false,
             'rewrite'               => false,
@@ -55 +56 @@
             'map_meta_cap'          => true,
             'menu_position'         => 20,
+            'menu_icon'             => 'dashicons-admin-page',
             'hierarchical'          => true,
             'rewrite'               => false,
@@ -86 +88 @@
             ),
             'map_meta_cap'          => true,
+            'menu_icon'             => 'dashicons-admin-media',
             'hierarchical'          => false,
             'rewrite'               => false,

trunk/tests/phpunit/tests/post/types.php

@@ -265 +265 @@
 
     /**
+     * @ticket 38844
+     */
+    public function test_get_post_type_object_includes_menu_icon_for_builtin_post_types() {
+        $this->assertEquals( 'dashicons-admin-post', get_post_type_object( 'post' )->menu_icon );
+        $this->assertEquals( 'dashicons-admin-page', get_post_type_object( 'page' )->menu_icon );
+        $this->assertEquals( 'dashicons-admin-media', get_post_type_object( 'attachment' )->menu_icon );
+    }
+
+    /**
      * @ticket 14761
      */