WordPress.org

Make WordPress Core


Ignore:
Timestamp:
02/06/2020 06:31:22 AM (8 months ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant.

This avoids the performance overhead of the function call every time dirname( __FILE__ ) was used instead of __DIR__.

This commit also includes:

  • Removing unnecessary parentheses from include/require statements. These are language constructs, not function calls.
  • Replacing include statements for several files with require_once, for consistency:
    • wp-admin/admin-header.php
    • wp-admin/admin-footer.php
    • wp-includes/version.php

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/about.php

    r46724 r47198  
    88
    99/** WordPress Administration Bootstrap */
    10 require_once( dirname( __FILE__ ) . '/admin.php' );
     10require_once __DIR__ . '/admin.php';
    1111
    1212/* translators: Page title of the About WordPress page in the admin. */
     
    1515list( $display_version ) = explode( '-', get_bloginfo( 'version' ) );
    1616
    17 include( ABSPATH . 'wp-admin/admin-header.php' );
     17require_once ABSPATH . 'wp-admin/admin-header.php';
    1818?>
    1919    <div class="wrap about__container">
     
    203203<?php
    204204
    205 include( ABSPATH . 'wp-admin/admin-footer.php' );
     205require_once ABSPATH . 'wp-admin/admin-footer.php';
    206206
    207207// These are strings we may use to describe maintenance/security releases, where we aim for no new strings.
Note: See TracChangeset for help on using the changeset viewer.