Make WordPress Core


Ignore:
Timestamp:
02/06/2020 06:31:22 AM (5 years ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant.

This avoids the performance overhead of the function call every time dirname( __FILE__ ) was used instead of __DIR__.

This commit also includes:

  • Removing unnecessary parentheses from include/require statements. These are language constructs, not function calls.
  • Replacing include statements for several files with require_once, for consistency:
    • wp-admin/admin-header.php
    • wp-admin/admin-footer.php
    • wp-includes/version.php

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/admin-header.php

    r45932 r47198  
    99header( 'Content-Type: ' . get_option( 'html_type' ) . '; charset=' . get_option( 'blog_charset' ) );
    1010if ( ! defined( 'WP_ADMIN' ) ) {
    11     require_once( dirname( __FILE__ ) . '/admin.php' );
     11    require_once __DIR__ . '/admin.php';
    1212}
    1313
     
    234234
    235235<div id="wpwrap">
    236 <?php require( ABSPATH . 'wp-admin/menu-header.php' ); ?>
     236<?php require ABSPATH . 'wp-admin/menu-header.php'; ?>
    237237<div id="wpcontent">
    238238
     
    290290
    291291if ( $parent_file == 'options-general.php' ) {
    292     require( ABSPATH . 'wp-admin/options-head.php' );
    293 }
     292    require ABSPATH . 'wp-admin/options-head.php';
     293}
Note: See TracChangeset for help on using the changeset viewer.