Make WordPress Core


Ignore:
Timestamp:
02/06/2020 06:31:22 AM (5 years ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant.

This avoids the performance overhead of the function call every time dirname( __FILE__ ) was used instead of __DIR__.

This commit also includes:

  • Removing unnecessary parentheses from include/require statements. These are language constructs, not function calls.
  • Replacing include statements for several files with require_once, for consistency:
    • wp-admin/admin-header.php
    • wp-admin/admin-footer.php
    • wp-includes/version.php

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/async-upload.php

    r47122 r47198  
    1616
    1717if ( defined( 'ABSPATH' ) ) {
    18     require_once( ABSPATH . 'wp-load.php' );
     18    require_once ABSPATH . 'wp-load.php';
    1919} else {
    20     require_once( dirname( dirname( __FILE__ ) ) . '/wp-load.php' );
     20    require_once dirname( __DIR__ ) . '/wp-load.php';
    2121}
    2222
    23 require_once( ABSPATH . 'wp-admin/admin.php' );
     23require_once ABSPATH . 'wp-admin/admin.php';
    2424
    2525header( 'Content-Type: text/plain; charset=' . get_option( 'blog_charset' ) );
    2626
    2727if ( isset( $_REQUEST['action'] ) && 'upload-attachment' === $_REQUEST['action'] ) {
    28     include( ABSPATH . 'wp-admin/includes/ajax-actions.php' );
     28    require ABSPATH . 'wp-admin/includes/ajax-actions.php';
    2929
    3030    send_nosniff_header();
Note: See TracChangeset for help on using the changeset viewer.