Make WordPress Core


Ignore:
Timestamp:
02/06/2020 06:31:22 AM (4 years ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant.

This avoids the performance overhead of the function call every time dirname( __FILE__ ) was used instead of __DIR__.

This commit also includes:

  • Removing unnecessary parentheses from include/require statements. These are language constructs, not function calls.
  • Replacing include statements for several files with require_once, for consistency:
    • wp-admin/admin-header.php
    • wp-admin/admin-footer.php
    • wp-includes/version.php

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/comment.php

    r47122 r47198  
    88
    99/** Load WordPress Bootstrap */
    10 require_once( dirname( __FILE__ ) . '/admin.php' );
     10require_once __DIR__ . '/admin.php';
    1111
    1212$parent_file  = 'edit-comments.php';
     
    5959
    6060        wp_enqueue_script( 'comment' );
    61         require_once( ABSPATH . 'wp-admin/admin-header.php' );
     61        require_once ABSPATH . 'wp-admin/admin-header.php';
    6262
    6363        $comment_id = absint( $_GET['c'] );
     
    7878        $comment = get_comment_to_edit( $comment_id );
    7979
    80         include( ABSPATH . 'wp-admin/edit-form-comment.php' );
     80        require ABSPATH . 'wp-admin/edit-form-comment.php';
    8181
    8282        break;
     
    107107        }
    108108
    109         require_once( ABSPATH . 'wp-admin/admin-header.php' );
     109        require_once ABSPATH . 'wp-admin/admin-header.php';
    110110
    111111        $formaction    = $action . 'comment';
     
    358358} // End switch.
    359359
    360 include( ABSPATH . 'wp-admin/admin-footer.php' );
     360require_once ABSPATH . 'wp-admin/admin-footer.php';
Note: See TracChangeset for help on using the changeset viewer.