Make WordPress Core


Ignore:
Timestamp:
02/06/2020 06:31:22 AM (4 years ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant.

This avoids the performance overhead of the function call every time dirname( __FILE__ ) was used instead of __DIR__.

This commit also includes:

  • Removing unnecessary parentheses from include/require statements. These are language constructs, not function calls.
  • Replacing include statements for several files with require_once, for consistency:
    • wp-admin/admin-header.php
    • wp-admin/admin-footer.php
    • wp-includes/version.php

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/includes/class-core-upgrader.php

    r47122 r47198  
    6363        global $wp_filesystem;
    6464
    65         include( ABSPATH . WPINC . '/version.php' ); // $wp_version;
     65        require ABSPATH . WPINC . '/version.php'; // $wp_version;
    6666
    6767        $start_time = time();
     
    162162        $wp_filesystem->chmod( $wp_dir . 'wp-admin/includes/update-core.php', FS_CHMOD_FILE );
    163163
    164         require_once( ABSPATH . 'wp-admin/includes/update-core.php' );
     164        require_once ABSPATH . 'wp-admin/includes/update-core.php';
    165165
    166166        if ( ! function_exists( 'update_core' ) ) {
     
    271271     */
    272272    public static function should_update_to_version( $offered_ver ) {
    273         include( ABSPATH . WPINC . '/version.php' ); // $wp_version; // x.y.z
     273        require ABSPATH . WPINC . '/version.php'; // $wp_version; // x.y.z
    274274
    275275        $current_branch = implode( '.', array_slice( preg_split( '/[.-]/', $wp_version ), 0, 2 ) ); // x.y
Note: See TracChangeset for help on using the changeset viewer.