Changeset 47198 for trunk/src/wp-admin/includes/class-wp-site-health-auto-updates.php

Timestamp:

02/06/2020 06:31:22 AM (3 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant.

This avoids the performance overhead of the function call every time dirname( __FILE__ ) was used instead of __DIR__.

This commit also includes:

• Removing unnecessary parentheses from include/require statements. These are language constructs, not function calls.
• Replacing include statements for several files with require_once, for consistency:
  • wp-admin/admin-header.php
  • wp-admin/admin-footer.php
  • wp-includes/version.php

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.

File:

• trunk/src/wp-admin/includes/class-wp-site-health-auto-updates.php (modified) (4 diffs)

trunk/src/wp-admin/includes/class-wp-site-health-auto-updates.php

@@ -14 +14 @@
      */
     public function __construct() {
-        include_once ABSPATH . 'wp-admin/includes/class-wp-upgrader.php';
+        require_once ABSPATH . 'wp-admin/includes/class-wp-upgrader.php';
     }
 
@@ -167 +167 @@
     public function test_wp_automatic_updates_disabled() {
         if ( ! class_exists( 'WP_Automatic_Updater' ) ) {
-            require_once( ABSPATH . 'wp-admin/includes/class-wp-automatic-updates.php' );
+            require_once ABSPATH . 'wp-admin/includes/class-wp-automatic-updates.php';
         }
 
@@ -337 +337 @@
         global $wp_filesystem;
 
-        include ABSPATH . WPINC . '/version.php'; // $wp_version; // x.y.z
+        require ABSPATH . WPINC . '/version.php'; // $wp_version; // x.y.z
 
         $skin    = new Automatic_Upgrader_Skin;
@@ -415 +415 @@
      */
     function test_accepts_dev_updates() {
-        include ABSPATH . WPINC . '/version.php'; // $wp_version; // x.y.z
+        require ABSPATH . WPINC . '/version.php'; // $wp_version; // x.y.z
         // Only for dev versions.
         if ( false === strpos( $wp_version, '-' ) ) {