Changeset 47198 for trunk/src/wp-admin/includes/class-wp-theme-install-list-table.php

Timestamp:

02/06/2020 06:31:22 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant.

This avoids the performance overhead of the function call every time dirname( __FILE__ ) was used instead of __DIR__.

This commit also includes:

• Removing unnecessary parentheses from include/require statements. These are language constructs, not function calls.
• Replacing include statements for several files with require_once, for consistency:
  • wp-admin/admin-header.php
  • wp-admin/admin-footer.php
  • wp-includes/version.php

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.

File:

• trunk/src/wp-admin/includes/class-wp-theme-install-list-table.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-theme-install-list-table.php

@@ -35 +35 @@
      */
     public function prepare_items() {
-        include( ABSPATH . 'wp-admin/includes/theme-install.php' );
+        require ABSPATH . 'wp-admin/includes/theme-install.php';
 
         global $tabs, $tab, $paged, $type, $theme_field_defaults;