Make WordPress Core


Ignore:
Timestamp:
02/06/2020 06:31:22 AM (7 years ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant.

This avoids the performance overhead of the function call every time dirname( __FILE__ ) was used instead of __DIR__.

This commit also includes:

  • Removing unnecessary parentheses from include/require statements. These are language constructs, not function calls.
  • Replacing include statements for several files with require_once, for consistency:
    • wp-admin/admin-header.php
    • wp-admin/admin-footer.php
    • wp-includes/version.php

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/includes/dashboard.php

    r47149 r47198  
    4646        if ( current_user_can( 'view_site_health_checks' ) ) {
    4747                if ( ! class_exists( 'WP_Site_Health' ) ) {
    48                         require_once( ABSPATH . 'wp-admin/includes/class-wp-site-health.php' );
     48                        require_once ABSPATH . 'wp-admin/includes/class-wp-site-health.php';
    4949                }
    5050
     
    16661666        if ( false === $response ) {
    16671667                // Include an unmodified $wp_version.
    1668                 include( ABSPATH . WPINC . '/version.php' );
     1668                require ABSPATH . WPINC . '/version.php';
    16691669
    16701670                $url     = 'http://api.wordpress.org/core/browse-happy/1.1/';
Note: See TracChangeset for help on using the changeset viewer.