Changeset 47198 for trunk/src/wp-admin/includes/deprecated.php

Timestamp:

02/06/2020 06:31:22 AM (6 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant.

This avoids the performance overhead of the function call every time dirname( __FILE__ ) was used instead of __DIR__.

This commit also includes:

• Removing unnecessary parentheses from include/require statements. These are language constructs, not function calls.
• Replacing include statements for several files with require_once, for consistency:
  • wp-admin/admin-header.php
  • wp-admin/admin-footer.php
  • wp-includes/version.php

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.

File:

• trunk/src/wp-admin/includes/deprecated.php (modified) (4 diffs)

trunk/src/wp-admin/includes/deprecated.php

@@ -764 +764 @@
 
     if ( ! class_exists( '_WP_Editors', false ) )
-        require_once( ABSPATH . WPINC . '/class-wp-editor.php' );
+        require_once ABSPATH . WPINC . '/class-wp-editor.php';
 
     $editor_id = 'content' . $num++;
@@ -1158 +1158 @@
         add_filter('update_feedback', $feedback);
 
-    include( ABSPATH . 'wp-admin/includes/class-wp-upgrader.php' );
+    require ABSPATH . 'wp-admin/includes/class-wp-upgrader.php';
     $upgrader = new Core_Upgrader();
     return $upgrader->upgrade($current);
@@ -1181 +1181 @@
         add_filter('update_feedback', $feedback);
 
-    include( ABSPATH . 'wp-admin/includes/class-wp-upgrader.php' );
+    require ABSPATH . 'wp-admin/includes/class-wp-upgrader.php';
     $upgrader = new Plugin_Upgrader();
     return $upgrader->upgrade($plugin);
@@ -1203 +1203 @@
         add_filter('update_feedback', $feedback);
 
-    include( ABSPATH . 'wp-admin/includes/class-wp-upgrader.php' );
+    require ABSPATH . 'wp-admin/includes/class-wp-upgrader.php';
     $upgrader = new Theme_Upgrader();
     return $upgrader->upgrade($theme);