Changeset 47198 for trunk/src/wp-admin/includes/file.php

Timestamp:

02/06/2020 06:31:22 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant.

This avoids the performance overhead of the function call every time dirname( __FILE__ ) was used instead of __DIR__.

This commit also includes:

• Removing unnecessary parentheses from include/require statements. These are language constructs, not function calls.
• Replacing include statements for several files with require_once, for consistency:
  • wp-admin/admin-header.php
  • wp-admin/admin-footer.php
  • wp-includes/version.php

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.

File:

• trunk/src/wp-admin/includes/file.php (modified) (3 diffs)

trunk/src/wp-admin/includes/file.php

@@ -1598 +1598 @@
     mbstring_binary_safe_encoding();
 
-    require_once( ABSPATH . 'wp-admin/includes/class-pclzip.php' );
+    require_once ABSPATH . 'wp-admin/includes/class-pclzip.php';
 
     $archive = new PclZip( $file );
@@ -1770 +1770 @@
     global $wp_filesystem;
 
-    require_once( ABSPATH . 'wp-admin/includes/class-wp-filesystem-base.php' );
+    require_once ABSPATH . 'wp-admin/includes/class-wp-filesystem-base.php';
 
     $method = get_filesystem_method( $args, $context, $allow_relaxed_file_ownership );
@@ -1796 +1796 @@
         }
 
-        require_once( $abstraction_file );
+        require_once $abstraction_file;
     }
     $method = "WP_Filesystem_$method";