Make WordPress Core


Ignore:
Timestamp:
02/06/2020 06:31:22 AM (7 years ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant.

This avoids the performance overhead of the function call every time dirname( __FILE__ ) was used instead of __DIR__.

This commit also includes:

  • Removing unnecessary parentheses from include/require statements. These are language constructs, not function calls.
  • Replacing include statements for several files with require_once, for consistency:
    • wp-admin/admin-header.php
    • wp-admin/admin-footer.php
    • wp-includes/version.php

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/includes/network.php

    r47156 r47198  
    117117                ) . '</p></div>';
    118118                echo '</div>';
    119                 include( ABSPATH . 'wp-admin/admin-footer.php' );
     119                require_once ABSPATH . 'wp-admin/admin-footer.php';
    120120                die();
    121121        }
     
    130130                echo '<p>' . __( 'Once the network is created, you may reactivate your plugins.' ) . '</p>';
    131131                echo '</div>';
    132                 include( ABSPATH . 'wp-admin/admin-footer.php' );
     132                require_once ABSPATH . 'wp-admin/admin-footer.php';
    133133                die();
    134134        }
     
    145145                echo '<a href="' . esc_url( admin_url() ) . '">' . __( 'Return to Dashboard' ) . '</a>';
    146146                echo '</div>';
    147                 include( ABSPATH . 'wp-admin/admin-footer.php' );
     147                require_once ABSPATH . 'wp-admin/admin-footer.php';
    148148                die();
    149149        }
Note: See TracChangeset for help on using the changeset viewer.