Make WordPress Core


Ignore:
Timestamp:
02/06/2020 06:31:22 AM (4 years ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant.

This avoids the performance overhead of the function call every time dirname( __FILE__ ) was used instead of __DIR__.

This commit also includes:

  • Removing unnecessary parentheses from include/require statements. These are language constructs, not function calls.
  • Replacing include statements for several files with require_once, for consistency:
    • wp-admin/admin-header.php
    • wp-admin/admin-footer.php
    • wp-includes/version.php

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/includes/theme.php

    r47122 r47198  
    3636    if ( false === $credentials ) {
    3737        if ( ! empty( $data ) ) {
    38             include_once( ABSPATH . 'wp-admin/admin-header.php' );
     38            require_once ABSPATH . 'wp-admin/admin-header.php';
    3939            echo $data;
    40             include( ABSPATH . 'wp-admin/admin-footer.php' );
     40            require_once ABSPATH . 'wp-admin/admin-footer.php';
    4141            exit;
    4242        }
     
    5151
    5252        if ( ! empty( $data ) ) {
    53             include_once( ABSPATH . 'wp-admin/admin-header.php' );
     53            require_once ABSPATH . 'wp-admin/admin-header.php';
    5454            echo $data;
    55             include( ABSPATH . 'wp-admin/admin-footer.php' );
     55            require_once ABSPATH . 'wp-admin/admin-footer.php';
    5656            exit;
    5757        }
     
    436436function themes_api( $action, $args = array() ) {
    437437    // Include an unmodified $wp_version.
    438     include( ABSPATH . WPINC . '/version.php' );
     438    require ABSPATH . WPINC . '/version.php';
    439439
    440440    if ( is_array( $args ) ) {
Note: See TracChangeset for help on using the changeset viewer.