Changeset 47198 for trunk/src/wp-admin/includes/theme.php

Timestamp:

02/06/2020 06:31:22 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant.

This avoids the performance overhead of the function call every time dirname( __FILE__ ) was used instead of __DIR__.

This commit also includes:

• Removing unnecessary parentheses from include/require statements. These are language constructs, not function calls.
• Replacing include statements for several files with require_once, for consistency:
  • wp-admin/admin-header.php
  • wp-admin/admin-footer.php
  • wp-includes/version.php

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.

File:

• trunk/src/wp-admin/includes/theme.php (modified) (3 diffs)

trunk/src/wp-admin/includes/theme.php

@@ -36 +36 @@
     if ( false === $credentials ) {
         if ( ! empty( $data ) ) {
-            include_once( ABSPATH . 'wp-admin/admin-header.php' );
+            require_once ABSPATH . 'wp-admin/admin-header.php';
             echo $data;
-            include( ABSPATH . 'wp-admin/admin-footer.php' );
+            require_once ABSPATH . 'wp-admin/admin-footer.php';
             exit;
         }
@@ -51 +51 @@
 
         if ( ! empty( $data ) ) {
-            include_once( ABSPATH . 'wp-admin/admin-header.php' );
+            require_once ABSPATH . 'wp-admin/admin-header.php';
             echo $data;
-            include( ABSPATH . 'wp-admin/admin-footer.php' );
+            require_once ABSPATH . 'wp-admin/admin-footer.php';
             exit;
         }
@@ -436 +436 @@
 function themes_api( $action, $args = array() ) {
     // Include an unmodified $wp_version.
-    include( ABSPATH . WPINC . '/version.php' );
+    require ABSPATH . WPINC . '/version.php';
 
     if ( is_array( $args ) ) {